Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On behalf of SuccessFactors : UploadCollection could not show full text of no-data-description and no-data-text #2672

Closed
mydavidzhang opened this issue Jan 12, 2021 · 1 comment · Fixed by #2674

Comments

@mydavidzhang
Copy link

Describe the bug
When set long text for no-data-description and no-data-text of UploadCollection they are shown "ellipsis" at end. User could not see the full texts.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/UploadCollection/
  2. Chrome dev tool to inspect elements of no-data-description and no-data-text for no data UploadCollection case, then change texts to longer ones.
  3. ellipsis shown for both texts at end

Isolated example
https://sap.github.io/ui5-webcomponents/playground/components/UploadCollection/ inspect element and change text to long ones.

Expected behavior
no-data-description and no-data-text should wrap the text the new line so that user could see full text.

Screenshots
UI5 Web Component
Screen Shot 2021-01-12 at 8 43 25 AM

SAP UI5 UploadCollection behavior is wrapping text (remove all items in the list) https://sapui5.hana.ondemand.com/#/entity/sap.m.UploadCollection/sample/sap.m.sample.UploadCollection
Screen Shot 2021-01-12 at 8 41 36 AM

Context

  • UI5 Web Components version : 0.29.0 (SuccessFactors is using this version)
  • OS/Platform: Any
  • Browser (if relevant): Any

Affected components (if known)
UploadCollection

Organization: (if applicable)
SuccessFactors

Priority: (optional) (Low, Medium, High or Very High)
High - SuccessFactors is using this component to deliver feature.

@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rd could you take a look of the issue?

It seems the noDataText and noDataDescrciption should wrap, instead of truncating. Could you confirm that and review possible solution: #2674

ilhan007 added a commit that referenced this issue Jan 13, 2021
Now the noDataText and noDateDescription texts will wrap upon overflow. Prior to this change the texts truncate.

FIXES: #2672
ilhan007 added a commit that referenced this issue Jan 13, 2021
Now the noDataText and noDateDescription texts will wrap upon overflow. Prior to this change the texts truncate.

FIXES: #2672
@ilhan007 ilhan007 self-assigned this Jan 13, 2021
@ilhan007 ilhan007 moved this from Issues to Completed in Maintenance - Topic RD Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants