Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming parameter --sapButton_BorderCornerRadius not connected #2830

Closed
uwe-klinger opened this issue Feb 17, 2021 · 2 comments · Fixed by #2840
Closed

Theming parameter --sapButton_BorderCornerRadius not connected #2830

uwe-klinger opened this issue Feb 17, 2021 · 2 comments · Fixed by #2840
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@uwe-klinger
Copy link

uwe-klinger commented Feb 17, 2021

Describe the bug

The theming parameter --sapButton_BorderCornerRadius is not connected to the respective UI5 parameter and therefore the button border radius do not react on theming in UI theme designer.

To reproduce

  1. https://sap.github.io/ui5-webcomponents/playground/components/Button/
  2. Open dev tools
  3. Pick any button
  4. Add element style to element: --sapButton_BorderCornerRadius: 0;
  5. PROBLEM: button has still rounded borders
  6. Add element style to element: --_ui5_button_border_radius: 0;
  7. Now, the button corner radius is gone

Isolated example

see above

Expected behavior

It should work like this:

--_ui5_button_border_radius: var(--sapButton_BorderCornerRadius);

Screenshots
If applicable, add screenshots to help explain your problem.

Context

  • UI5 Web Components version: 1.0.0-rc.11
  • OS/Platform: doesn't matter
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components (if known)

Log output / Any errors in the console

{...}

Organization: (if applicable)

@ilhan007 ilhan007 added TOPIC B bug This issue is a bug in the code labels Feb 19, 2021
@ilhan007 ilhan007 added this to New Issues in Maintenance - Topic B via automation Feb 19, 2021
@ilhan007 ilhan007 self-assigned this Feb 19, 2021
Maintenance - Topic B automation moved this from New Issues to Completed Feb 19, 2021
ilhan007 added a commit that referenced this issue Feb 19, 2021
There is a standard CSS variable --sapButton_BorderCornerRadius meant to be used for the Button's border-radius. It is 0.25rem in Fiori3 and 0.375rem in HCB and HCW themes. In terms of metrics nothing changes, we use the same values, but now we allow customization via the ThemeDesigner as we apply standard CSS variable.

FIXES: #2830
@uwe-klinger
Copy link
Author

Hi @ilhan007,

thanks a lot for the quick solution! 👍

Best regards,
Uwe

@ilhan007
Copy link
Member

Hi @uwe-klinger welcome, thanks for letting us know

BR,
ilhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants