Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y issue: Focus gets trapped in ui5-li-custom list #2849

Closed
lateefsofi opened this issue Feb 22, 2021 · 1 comment · Fixed by #2870
Closed

a11y issue: Focus gets trapped in ui5-li-custom list #2849

lateefsofi opened this issue Feb 22, 2021 · 1 comment · Fixed by #2870
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF SF_ACC TOPIC P

Comments

@lateefsofi
Copy link

Describe the bug
Focus gets trapped within ui5-li-custom List when navigating through keyboard.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/ui5-webcomponents-forked-d7dp3
  2. Press tab key to navigate through list items.
  3. While navigation through last element of the list, focus gets back to first element.

Isolated example
https://codesandbox.io/s/ui5-webcomponents-forked-d7dp3

Expected behavior
User should be able to navigate to next element on pressing tab in the list. Behaviour should be same like StandardListItem.

Screenshots
NA

Context

  • UI5 Web Components version: 0.29.3
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components
List and CustomListItem

Log output / Any errors in the console

NA

Organization:
Success Factors

Priority: (optional) (Low, Medium, High or Very High)
High

@TeodorTaushanov TeodorTaushanov added bug This issue is a bug in the code Medium Prio TOPIC Core labels Feb 22, 2021
@TeodorTaushanov TeodorTaushanov added this to New in Maintenance - Topic Core via automation Feb 22, 2021
@TeodorTaushanov TeodorTaushanov added this to Issues in Maintenance - Topic P via automation Feb 22, 2021
@TeodorTaushanov
Copy link
Member

Hi @SAP/ui5-webcomponents-topic-p, can you check this issue?

@nnaydenow nnaydenow moved this from Issues to In Progress in Maintenance - Topic P Feb 25, 2021
@nnaydenow nnaydenow self-assigned this Feb 25, 2021
Maintenance - Topic P automation moved this from In Progress to Completed Feb 26, 2021
ilhan007 pushed a commit that referenced this issue Feb 26, 2021
Key up and key down events should be prevented when the focus is on child element of the ui5-li-custom. Exception is made for the case where Tab key is pressed so the logic about item navigation from the extended class to be executed.

Fixes: #2849
ilhan007 pushed a commit that referenced this issue Feb 26, 2021
Key up and key down events should be prevented when the focus is on child element of the ui5-li-custom. Exception is made for the case where Tab key is pressed so the logic about item navigation from the extended class to be executed.

Fixes: #2849
ilhan007 pushed a commit that referenced this issue Feb 26, 2021
Key up and key down events should be prevented when the focus is on child element of the ui5-li-custom. Exception is made for the case where Tab key is pressed so the logic about item navigation from the extended class to be executed.

Fixes: #2849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF SF_ACC TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants