Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-avatar: click event triggler twice when it's interactive #2943

Closed
JosephineSu opened this issue Mar 15, 2021 · 6 comments · Fixed by #2967
Closed

ui5-avatar: click event triggler twice when it's interactive #2943

JosephineSu opened this issue Mar 15, 2021 · 6 comments · Fixed by #2967
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC P

Comments

@JosephineSu
Copy link

JosephineSu commented Mar 15, 2021

Describe the bug
When using avatar, setting the value of interactive prop to "true" directly in avatar component, it always triggler twice. In our app, we want to open another tab in window once user click avatar. But actually it will open two new tabs.
To reproduce
Steps to reproduce the behavior:

  1. Go to "Goals"
    2.select instance: "MLT - Demo for target-baseline and tb buildin"
  2. select goal: "test cgrant"
  3. click avatar in "AlignUp" in the lower right conner.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Context

  • UI5 Web Components version
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components (if known)

Log output / Any errors in the console

{...}

Organization: (if applicable)

Priority: (optional) (Low, Medium, High or Very High)

Setting priority would indicate the importance of the issue
and would help the process of dispatching and processing.

To set the appropriate priority, you need to consider the impact
and if the issue:
High

  • Breaks entire application or system - High and Very High
  • Is accessibility one (Screan Reader, Keyboard Handling) - Medium and High
  • Is functional one and makes a single component unusable - Medium and High
  • Is visual, styling one - Low and Medium

Note: the priority would be re-evaluated by the issue processors, according to the project internal criterias

Business impact: (mandatory for "Very High")
Hign

@d3xter666
Copy link
Contributor

The avatar indeed fires the click event twice.

However, with proper debouncing the impact of this behaviour on the application side could be significantly improved.

@d3xter666 d3xter666 self-assigned this Mar 16, 2021
@d3xter666 d3xter666 added bug This issue is a bug in the code Medium Prio SAP SF TOPIC P labels Mar 16, 2021
@d3xter666 d3xter666 added this to Issues in Maintenance - Topic P via automation Mar 16, 2021
@d3xter666 d3xter666 removed their assignment Mar 16, 2021
@JosephineSu
Copy link
Author

Hi @d3xter666 ,
May I know when will this issue be resolved?

@ilhan007
Copy link
Member

Hi @JosephineSu the issue is dispatched to the responsible team. They are processing the issues by priority
For example, these issues, also filed by SFSF, are before the current one
#2880
#2910

When you file an issue, a bug, nobody can say when the issue will be resolved, however we make our best to fix them as soon as possible. It's just that this is not the only issue.

@SAP/ui5-webcomponents-topic-p could you take a look of the issue.

@JosephineSu
Copy link
Author

Ok, got it. Thank you.

@dobrinyonkov dobrinyonkov self-assigned this Mar 18, 2021
@dobrinyonkov dobrinyonkov moved this from Issues to In Progress in Maintenance - Topic P Mar 19, 2021
Maintenance - Topic P automation moved this from In Progress to Completed Mar 23, 2021
ilhan007 pushed a commit that referenced this issue Mar 23, 2021
We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).
FIXES: #2943
ilhan007 pushed a commit that referenced this issue Mar 23, 2021
We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).
FIXES: #2943
ilhan007 pushed a commit that referenced this issue Mar 23, 2021
We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).
FIXES: #2943
@ilhan007
Copy link
Member

Hi @JosephineSu the issue will be included in 0.29.10 and 0.31.2 on 29-30 March

@JosephineSu
Copy link
Author

thanks, Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants