Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-dialog: [AXE] ARIA dialog and alertdialog nodes must have an accessible name #2946

Closed
GongRichard opened this issue Mar 15, 2021 · 2 comments · Fixed by #3044
Closed

Comments

@GongRichard
Copy link

GongRichard commented Mar 15, 2021

Describe the bug
AXE issue: ARIA dialog and alertdialog nodes must have an accessible name

To reproduce
Steps to reproduce the behavior:

  1. Go to page https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock#/goal-detail?targetUserId=undefined&templateType=tgm&templateId=583&id=11003
  2. click +12 avatar on the right bottom of Goal Alignment section of the page
  3. use AXE browser plugin to scan the page, it will show one serious error related with ui5-dialog.

Actually the dialog already defines aria-labelledby property, I don't know why AXE still reports this error.
BTW, all the dialogs in our project have this issue.

Screenshots
2021-03-15_16-05-32

Context

  • UI5 Web Components version: 0.29.7
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}
@d3xter666
Copy link
Contributor

There is aria-labelledby, but the tool does not detect it

@ilhan007
Copy link
Member

ilhan007 commented Apr 1, 2021

Hello @GongRichard we released a fix with 0.29.13 can you re-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants