Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-avatar): fix click event fired twice #2967

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

dobrinyonkov
Copy link
Contributor

@dobrinyonkov dobrinyonkov commented Mar 18, 2021

We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).

Also additional fixes have been performed:

  • the content no longer scrolls when the SPACE key is pressed over "interactive" avatar.
  • AvatarGroup now checks the target of the click event in order to detect whether an avatar or the overflow button is clicked.

FIXES: #2943

ilhan007
ilhan007 previously approved these changes Mar 18, 2021
@ilhan007 ilhan007 merged commit 377c9bc into SAP:master Mar 23, 2021
ilhan007 pushed a commit that referenced this pull request Mar 23, 2021
We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).
FIXES: #2943
ilhan007 pushed a commit that referenced this pull request Mar 23, 2021
We used to fire a custom event, but did not stop the native one and end up firing two "click" events.
Now, the native one is stopped properly (we need to fire the custom one, so the noConflict ui5-click is also fired).
FIXES: #2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-avatar: click event triggler twice when it's interactive
2 participants