Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-select: aria-expanded attribute is missing in initial status #2987

Closed
zhangliangyi opened this issue Mar 22, 2021 · 0 comments · Fixed by #2991
Closed

ui5-select: aria-expanded attribute is missing in initial status #2987

zhangliangyi opened this issue Mar 22, 2021 · 0 comments · Fixed by #2991
Assignees
Labels

Comments

@zhangliangyi
Copy link

Describe the bug
When rendering a ui5-select, the aria-expand property is missing initially. Until user opens the option popover, the property appears and works as expected.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Select/
  2. Check the dom in any ui5-select sample and the aria-expanded property is not found.
  3. Click the component to open the popover, then aria-expanded property appears as an attribute.

Expected behavior
The aria-expand="false" should be in the DOM initially when a ui5-select is rendered.

Context

  • UI5 Web Components version: 0.29.7
  • OS/Platform: MacOS
  • Browser (if relevant): Edge
  • Other information: N/A

Affected components (if known)
ui5-select

Organization: (if applicable)
SAP SF

Priority: (optional) (Low, Medium, High or Very High)
Medium

Setting priority would indicate the importance of the issue
and would help the process of dispatching and processing.

To set the appropriate priority, you need to consider the impact
and if the issue:

  • Breaks entire application or system - High and Very High
  • Is accessibility one (Screan Reader, Keyboard Handling) - Medium and High
  • Is functional one and makes a single component unusable - Medium and High
  • Is visual, styling one - Low and Medium

Note: the priority would be re-evaluated by the issue processors, according to the project internal criterias

Business impact: (mandatory for "Very High")

@ilhan007 ilhan007 added this to Issues in Maintenance - Topic P via automation Mar 23, 2021
@ilhan007 ilhan007 added SAP SF Medium Prio bug This issue is a bug in the code labels Mar 23, 2021
@ilhan007 ilhan007 self-assigned this Mar 23, 2021
ilhan007 added a commit that referenced this issue Mar 23, 2021
We used to return undefined for aria-expanded upon initial rendering, causing the attribute to not render at all, now we always return boolean and the attribute is added with "false" on initial rendering.

FIXES: #2987
Maintenance - Topic P automation moved this from Issues to Completed Mar 23, 2021
ilhan007 added a commit that referenced this issue Mar 23, 2021
We used to return undefined for aria-expanded upon initial rendering, causing the attribute to not render at all, now we always return boolean and the attribute is added with "false" on initial rendering.

FIXES: #2987
ilhan007 added a commit that referenced this issue Mar 23, 2021
We used to return undefined for aria-expanded upon initial rendering, causing the attribute to not render at all, now we always return boolean and the attribute is added with "false" on initial rendering.

FIXES: #2987
ilhan007 added a commit that referenced this issue Mar 23, 2021
We used to return undefined for aria-expanded upon initial rendering, causing the attribute to not render at all, now we always return boolean and the attribute is added with "false" on initial rendering.

FIXES: #2987
ilhan007 added a commit that referenced this issue Mar 31, 2021
We used to return undefined for aria-expanded upon initial rendering, causing the attribute to not render at all, now we always return boolean and the attribute is added with "false" on initial rendering.

FIXES: #2987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants