Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange Tree behavior when Text overflows #3069

Closed
MaxRumpf opened this issue Mar 31, 2021 · 1 comment · Fixed by #3075
Closed

Strange Tree behavior when Text overflows #3069

MaxRumpf opened this issue Mar 31, 2021 · 1 comment · Fixed by #3075
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P

Comments

@MaxRumpf
Copy link

Hey ui5-webcomponents-Team,

We have used your Tree-Component in our React Web App.
What we noticed is that if the items are too long to be displayed in one line, there is a "..." added to the end of the text. But then they get shifted to the left, therefore making the impression that the items coming after it are children of the the one shifted to the left. This also gets worse the smaller the browser window is.
Please see the attached screenshots. These are all root-level items, there is no nesting visible, so they should all be aligned.
TreeFailure
TreeFailure2

Thanks in advance 😃
@unazko unazko self-assigned this Mar 31, 2021
@unazko unazko added bug This issue is a bug in the code Medium Prio TOPIC P labels Apr 1, 2021
@unazko unazko added this to Issues in Maintenance - Topic P via automation Apr 1, 2021
@unazko unazko removed their assignment Apr 1, 2021
@unazko
Copy link
Contributor

unazko commented Apr 1, 2021

Hello @SAP/ui5-webcomponents-topic-p,

The issue is reproducible with the following snipped:
https://codesandbox.io/s/busy-flower-p6y3v?file=/index.html

Could you please process the issue further.

Best Regards,
Boyan

@plamenivanov91 plamenivanov91 self-assigned this Apr 1, 2021
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Apr 1, 2021
@plamenivanov91
fix(ui5-li-tree): fixed incorrect tree items alignment
417c9be 
When there was ellipsis of the text of the tree items, the ones
which got truncated were misaligned with the ones which weren't.
Now they are correctly aligned.

Fixes: SAP#3069
@plamenivanov91 plamenivanov91 mentioned this issue Apr 1, 2021
Merged
2 tasks
Maintenance - Topic P automation moved this from Issues to Completed Apr 1, 2021
ilhan007 pushed a commit that referenced this issue Apr 1, 2021
@plamenivanov91
fix(ui5-li-tree): fixed incorrect tree items alignment (#3075)
4b83c7b 
When there was ellipsis of the text of the tree items, the ones
which got truncated were misaligned with the ones which weren't.
Now they are correctly aligned.

Fixes: #3069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Maintenance - Topic P
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-li-tree): fixed incorrect tree items alignment plamenivanov91/ui5-webcomponents
3 participants
@MaxRumpf @plamenivanov91 @unazko