Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: icon is not displayed next to the selected option's text #3344

Closed
1 of 4 tasks
ilhan007 opened this issue May 28, 2021 · 0 comments · Fixed by #3348
Closed
1 of 4 tasks

Select: icon is not displayed next to the selected option's text #3344

ilhan007 opened this issue May 28, 2021 · 0 comments · Fixed by #3348
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P

Comments

@ilhan007
Copy link
Member

ilhan007 commented May 28, 2021 •
edited

Bug Description

If an option with icon is selected, its icon is not displayed within the Select's input field.

Expected Behavior

The icon should be present within the Select's input field by the Fiori 3 spec and can be seen here:
https://openui5nightly.hana.ondemand.com/entity/sap.m.Select/sample/sap.m.sample.SelectWithIcons

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/Select/
  2. Find the "Select with Value State and Value State Message" sample
  3. Select any option - icon is not displayed in the input field

Context

  • UI5 Web Components version: { master }
  • OS/Platform: any
  • Browser: any
  • Affected component: ui5-select

Priority

  • Low
  • Medium
  • High
  • Very High
@ilhan007 ilhan007 added bug This issue is a bug in the code TOPIC P labels May 28, 2021
@ilhan007 ilhan007 added this to Issues in Maintenance - Topic P via automation May 28, 2021
@nnaydenow nnaydenow mentioned this issue May 28, 2021
Merged
Maintenance - Topic P automation moved this from Issues to Completed May 28, 2021
ilhan007 pushed a commit that referenced this issue May 28, 2021
@nnaydenow
fix(ui5-select): display the selected option's icon (#3348)
dac8183 
Fixes: #3344
kskondov pushed a commit that referenced this issue May 31, 2021
@nnaydenow @kskondov
fix(ui5-select): display the selected option's icon (#3348)
9d89fdc 
Fixes: #3344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-select): display icon of selected option
1 participant
@ilhan007