Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-step-input fires 2 change events when 0 is cleared #3457

Closed
1 of 4 tasks
agauyeung opened this issue Jun 22, 2021 · 1 comment · Fixed by #3474
Closed
1 of 4 tasks

ui5-step-input fires 2 change events when 0 is cleared #3457

agauyeung opened this issue Jun 22, 2021 · 1 comment · Fixed by #3474
Assignees
@tsanislavgatev
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC B
Projects
Maintenance - Topic B

Comments

@agauyeung
Copy link

Bug Description

The step input component fires 2 change events when the 0 is manually cleared to empty.

Expected Behavior

The number should still change back to 0 but no change event should be fired.

Steps to Reproduce

  1. Go to the code sandbox below.
  2. Highlight the 0 inside the step input and delete it.
  3. Click outside of the step input.
  4. Issue: A change event is fired.
  5. Issue: A second change event is fired.
  6. 0 is automatically placed back into the step input box.

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

  • UI5 Web Components version: 0.29.19
  • OS/Platform: Windows
  • Browser: Chrome
  • Affected component: Step Input

Priority

  • Low
  • Medium
  • High
  • Very High

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SuccessFactors
@NHristov-sap NHristov-sap self-assigned this Jun 23, 2021
@NHristov-sap NHristov-sap added bug This issue is a bug in the code Medium Prio TOPIC B High Prio and removed Medium Prio labels Jun 23, 2021
@NHristov-sap NHristov-sap added this to New Issues in Maintenance - Topic B via automation Jun 23, 2021
@NHristov-sap
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

The issue is reproducible, please take care of it.

Best Regards,
Nikolay Hristov

@NHristov-sap NHristov-sap removed their assignment Jun 23, 2021
@tsanislavgatev tsanislavgatev self-assigned this Jun 25, 2021
@tsanislavgatev tsanislavgatev mentioned this issue Jun 25, 2021
Merged
@tsanislavgatev tsanislavgatev moved this from New Issues to In Progress in Maintenance - Topic B Jun 25, 2021
Maintenance - Topic B automation moved this from In Progress to Completed Jul 1, 2021
tsanislavgatev added a commit that referenced this issue Jul 1, 2021
@tsanislavgatev
fix(ui5-step-input): firing step input once when value is deleted (#3474
a5f27f2 
)

fixes: #3457
ilhan007 pushed a commit that referenced this issue Jul 2, 2021
@tsanislavgatev @ilhan007
fix(ui5-step-input): firing step input once when value is deleted (#3474
46f54f8 
)

Fixes: #3457
ilhan007 pushed a commit that referenced this issue Jul 2, 2021
@tsanislavgatev @ilhan007
fix(ui5-step-input): firing step input once when value is deleted (#3474
2bcb78b 
)

fixes: #3457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC B
Projects
Maintenance - Topic B
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-step-input): firing step input once when value is deleted SAP/ui5-webcomponents
4 participants
@agauyeung @tsanislavgatev @ilhan007 @NHristov-sap