Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-li-groupheader: no bottom space in compact mode #3606

Closed
1 of 4 tasks
GongRichard opened this issue Aug 6, 2021 · 3 comments · Fixed by #3610
Closed
1 of 4 tasks

ui5-li-groupheader: no bottom space in compact mode #3606

GongRichard opened this issue Aug 6, 2021 · 3 comments · Fixed by #3610
Assignees
@nnaydenow
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P
Projects
Maintenance - Topic P

Comments

@GongRichard
Copy link

Bug Description

There is no bottom space for group header text in compact mode.

Expected Behavior

There should have bottom space for group header text in compact mode.

Steps to Reproduce

  1. Go to 'https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&noFirstTimeGuidance'
  2. Check group header text in the left panel of page

2021-08-06_10-37-29

Context

  • UI5 Web Components version: {0.31.12}
  • OS/Platform: {Mac OS}
  • Browser: {Chrome}
  • Affected component: {ui5-li-groupheader}

Priority

  • Low
  • Medium
  • High
  • Very High

Stakeholder Info (if applicable)

  • Organization: {SAP SuccessFactors}
@elenastoyanovaa elenastoyanovaa self-assigned this Aug 6, 2021
@elenastoyanovaa elenastoyanovaa added bug This issue is a bug in the code Medium Prio TOPIC P labels Aug 6, 2021
@elenastoyanovaa elenastoyanovaa removed their assignment Aug 6, 2021
@elenastoyanovaa elenastoyanovaa added this to Issues in Maintenance - Topic P via automation Aug 6, 2021
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p ,

There seems to be an issue with the alignment of the group header list item in compact mode. As a reference in UI5, the group header list item results in 44px, but in the web components, the height is 31px. Could you please check?

Kind Regards,
Elena

@nnaydenow nnaydenow self-assigned this Aug 6, 2021
@nnaydenow nnaydenow mentioned this issue Aug 6, 2021
Merged
@nnaydenow nnaydenow moved this from Issues to In Progress in Maintenance - Topic P Aug 6, 2021
@ilhan007 ilhan007 added the SAP SF label Aug 6, 2021
Maintenance - Topic P automation moved this from In Progress to Completed Aug 6, 2021
ilhan007 pushed a commit that referenced this issue Aug 6, 2021
@nnaydenow
fix(ui5-li-groupheader): fix row height (#3610)
79d259e 
The space between bottom border and text should be 0.5rem by visual specification.

Fixes: #3606
@ilhan007
Copy link
Member

ilhan007 commented Aug 6, 2021

Hello @GongRichard the fix is going to be released with 0.31.15 (9-10 Aug)

ilhan007 pushed a commit that referenced this issue Aug 9, 2021
@nnaydenow @ilhan007
fix(ui5-li-groupheader): fix row height (#3610)
9ee7ea5 
The space between bottom border and text should be 0.5rem by visual specification.

Fixes: #3606
@ilhan007
Copy link
Member

Hello @GongRichard Fix is released with 0.31.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnaydenow nnaydenow

Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P
Projects
Maintenance - Topic P
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-li-groupheader): fix row height
4 participants
@elenastoyanovaa @GongRichard @ilhan007 @nnaydenow