New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-list): preventing space keydown #4088

Merged

ilhan007 merged 1 commit into SAP:master from nnaydenow:li-space

Oct 8, 2021

Contributor

nnaydenow commented Oct 7, 2021

Preventing the Space key on keydown is redundant since it should be already handled in its children separately.

Fixes: #4049


          fix(ui5-list): preventing space keydown

628fd00

nnaydenow requested review from ilhan007 and dobrinyonkov

October 7, 2021 11:34

ilhan007 approved these changes

View reviewed changes

Member

ilhan007 left a comment

+1 SPACE is handled and prevented in ListItem.js

dobrinyonkov approved these changes

View reviewed changes

ilhan007 merged commit e9c5287 into SAP:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet