Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-shellbar): introduce accessibilityTexts property #4377

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Nov 22, 2021

New property from type Object, called accessibilityTexts is introduced to allow customization of some internal parts of the ShellBar web component via stable API. Currently the only thing available on the object is the profileButtonTitle to define the profile button tooltip, showing up on hover.

Fixes: #4009

In a plain html, using the property would look like this:

<script>
    sbAcc.accessibilityTexts = {
	  profileButtonTitle: "John Dow",
    };
</script>

But in a React or similar programming model environment, one should be able to bind a object to this property in the template in a declarative manner.

@ilhan007 ilhan007 merged commit f762e76 into master Nov 23, 2021
@ilhan007 ilhan007 deleted the feat-sb-accTexts branch November 23, 2021 09:58
ilhan007 added a commit that referenced this pull request Nov 23, 2021
New property from type Object, called accessibilityTexts is introduced to allow customization of some internal parts of the ShellBar web component via stable API. Currently the only thing available on the object is the profileButtonTitle to define the profile button tooltip, showing up on hover.

Fixes: #4009
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this pull request Dec 13, 2021
New property from type Object, called accessibilityTexts is introduced to allow customization of some internal parts of the ShellBar web component via stable API. Currently the only thing available on the object is the profileButtonTitle to define the profile button tooltip, showing up on hover.

Fixes: SAP#4009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-shellbar profile button title override
3 participants