Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support height for the Select's popover #4503

Closed
1 of 4 tasks
fkolar opened this issue Dec 17, 2021 · 3 comments
Closed
1 of 4 tasks

Support height for the Select's popover #4503

fkolar opened this issue Dec 17, 2021 · 3 comments
Labels
feature request Medium Prio TOPIC P
Projects
Planning - Topic P

Comments

@fkolar
Copy link
Member

fkolar commented Dec 17, 2021

Feature Request Description

Currently when using select the Popover with options takes up the whole height and it is not really usable for some situation on the screen.

Screen Shot 2021-12-17 at 9 56 01 PM

vs

Screen Shot 2021-12-17 at 9 56 07 PM

Proposed Solution

Please provide a solution similar to
https://fundamental-ngx.netlify.app/#/core/select#max-height

Proposed Alternatives

A clear and concise description of any alternative solutions or features you've considered. Since we are thinking to re-do some of the screen in current procurement solution we need to have this option.

Priority

  • Low
  • Medium
  • High
  • Very High

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

  • Organization: SAP Ariba
  • Bussiness impact: NG.PROC, GB
@fkolar fkolar changed the title Select Popover height Support height for the Select's popover Dec 17, 2021
@MapTo0 MapTo0 added this to New in Planning - Topic P via automation Dec 20, 2021
@MapTo0
Copy link
Member

MapTo0 commented Dec 20, 2021 •
edited
Loading

Dear Colleagues,

I guess UX should be involved here. Furthermore, some input of the Popover's team should be provided if it is possible to assign custom height / max-height to the Popover.

Regards,
Martin

@dobrinyonkov
Copy link
Contributor

Internal reference: BGSOFUIPIRIN-6484

@dobrinyonkov dobrinyonkov moved this from New to Approved in Planning - Topic P Feb 29, 2024
@dobrinyonkov dobrinyonkov mentioned this issue Feb 29, 2024
Closed
1 task
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Jun 4, 2024
@plamenivanov91
feat(ui5-select): introduced popoverMaxHeight property
0ede1da 
The new property takes integer (the pixels) and restricts the maximum
height of the Select's popover.

Also maxHeight property is introduced in the Popover so the above
mentioned requirement is possible and calculated correctly.

Implements: SAP#4503
@plamenivanov91 plamenivanov91 mentioned this issue Jun 4, 2024
Merged
plamenivanov91 added a commit that referenced this issue Jun 6, 2024
@plamenivanov91
feat(ui5-select): introduced 'popover' part (#9120)
3c03e17 
Introduced `popover` `csspart` to the Select.

Now we can alter the popover styles (its max-height for example) with the following CSS:


```
	#selectPopoverMaxHeight[ui5-select]::part(popover) {
		max-height: 120px;
	}
```

Implements: #4503
@plamenivanov91
Copy link
Contributor

You can now alter the popover max-height by using the newly introduced part as shown here
#9120

Regards,
Plamen Ivanov

Planning - Topic P automation moved this from Approved to Completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Medium Prio TOPIC P
Projects
Planning - Topic P
Status: Completed
Planning - Topic P
Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MapTo0 @plamenivanov91 @fkolar @dobrinyonkov