Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-icon): accessibleRole property implemented #4548

Merged
merged 1 commit into from
Jan 17, 2022
Merged

feat(ui5-icon): accessibleRole property implemented #4548

merged 1 commit into from
Jan 17, 2022

Conversation

dobrinyonkov
Copy link
Contributor

Fixes: #4499

nnaydenow
nnaydenow approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fifoosid,

Could you please check the JSDOC? Everything other looks good to me.

Regards,
Nayden

@ilhan007 ilhan007 merged commit 6d6cf6f into SAP:master Jan 17, 2022
@ilhan007 ilhan007 mentioned this pull request Jan 17, 2022
Closed
4 tasks
@dkris dkris mentioned this pull request Feb 2, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

@kineticjs kineticjs Awaiting requested review from kineticjs

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon does not have accessible-role
3 participants
@dobrinyonkov @nnaydenow @ilhan007