Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][1.1.2][ResponsivePopover][BUG][Expected within two weeks] Arrow going out of bounds #4797

Closed
1 task done
sfsf-xweb-sh opened this issue Feb 22, 2022 · 3 comments · Fixed by #4960
Closed
1 task done

[SF][1.1.2][ResponsivePopover][BUG][Expected within two weeks] Arrow going out of bounds #4797

sfsf-xweb-sh opened this issue Feb 22, 2022 · 3 comments · Fixed by #4960
Assignees
@gmkv
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD
Projects
Maintenance - Topic RD

Comments

@sfsf-xweb-sh
Copy link

Dear UI5 team,

This is SuccessFactors Web Experience Shanghai team. We found this issue in the process of upgrading to Fiori Next, the version we are using is 1.1.2

Bug Description

Responsive popover's arrow is going out of bounds, please see screenshot.
Screen Shot 2022-02-22 at 5 57 16 PM

Priority

  • Medium

  • Organization: SF
@dobrinyonkov dobrinyonkov self-assigned this Feb 22, 2022
@dobrinyonkov dobrinyonkov added bug This issue is a bug in the code SAP SF High Prio labels Feb 23, 2022
@dobrinyonkov
Copy link
Contributor

Hi @gmkv,

as we talked, this might be an edge case not coverd by the fix #4581.

Also, with the change for the default paddings #4567, the misalignment is slightly less but still might need an investigation for a different solution.

Regards,
Dobrin

@dobrinyonkov dobrinyonkov added this to New Issues in Maintenance - Topic RD via automation Feb 23, 2022
@dobrinyonkov dobrinyonkov removed their assignment Feb 23, 2022
@gmkv gmkv added the TOPIC RD label Feb 25, 2022
@gmkv gmkv assigned gmkv and unassigned gmkv Feb 25, 2022
@gmkv
Copy link
Contributor

gmkv commented Mar 6, 2022 •
edited

Hi @sfsf-xweb-sh

Is it possible to recreate/isolate this issue in a codesandbox here?

gmkv added a commit that referenced this issue Mar 25, 2022
@gmkv
fix(ui5-popover): prevent arrow placement over popover's rounded corners
0101129 
Improved logic from #4599 for clamping the arrow's placement.

Fixes #4797
@gmkv
Copy link
Contributor

gmkv commented Mar 25, 2022

Issue occurs when the opener is a small element and the Popover's vertical align is set to align to the top/bottom of that opener.

@gmkv gmkv moved this from New Issues to In Progress in Maintenance - Topic RD Mar 25, 2022
@gmkv gmkv mentioned this issue Mar 25, 2022
Merged
Maintenance - Topic RD automation moved this from In Progress to Completed Mar 28, 2022
gmkv added a commit that referenced this issue Mar 28, 2022
@gmkv
fix(ui5-popover): prevent arrow placement over popover's rounded corn…
994871d 
…ers (#4960)

Improved logic from #4599 for clamping the arrow's placement.

Fixes #4797
ilhan007 pushed a commit that referenced this issue Mar 30, 2022
@gmkv @ilhan007
fix(ui5-popover): prevent arrow placement over popover's rounded corn…
66604c3 
…ers (#4960)

Improved logic from #4599 for clamping the arrow's placement.

Fixes #4797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmkv gmkv

Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD
Projects
Maintenance - Topic RD
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-popover): prevent arrow placement over popover's rounded corners SAP/ui5-webcomponents
3 participants
@gmkv @dobrinyonkov @sfsf-xweb-sh