Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][a11y][ui5-date-picker] Date picker has horizontal scroll bar at 320px width responsive view #5641

Closed
1 of 4 tasks
zhangliangyi opened this issue Aug 8, 2022 · 4 comments · Fixed by #6196
Closed
1 of 4 tasks
Assignees
Labels

Comments

@zhangliangyi
Copy link

Bug Description

When font-size of body is set as 16px, the calendar dialog opened will have horizontal scroll bar at 320px width responsive view.

Expected Behavior

Horizontal scroll bar should not be displayed.

Steps to Reproduce

When font-size of body is set as 16px, per the css variable defined in

The calendar width will be 328px which causes the display of scroll bar

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

  • UI5 Web Components version: 1.6.0
  • OS/Platform: MacOS
  • Browser: Edge
  • Affected component: ui5-date-picker

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SF
  • Business impact: {...}
@kskondov kskondov added TOPIC B bug This issue is a bug in the code Medium Prio SAP SF labels Aug 10, 2022
@nikolay-kolarov nikolay-kolarov added this to New Issues in Maintenance - Topic B via automation Aug 26, 2022
@nikolay-kolarov
Copy link

Hello @SAP/ui5-webcomponents-topic-b ,

Could you please have a look?

Thanks,
Nikolay

@unazko unazko self-assigned this Aug 30, 2022
@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B Aug 30, 2022
@unazko
Copy link
Contributor

unazko commented Aug 31, 2022

Hello @zhangliangyi,

Is there a specific reason for setting the font-size to 16px?

Best Regards,
Boyan Rakilovski

@unazko unazko added the SF_ACC label Aug 31, 2022
@zhangliangyi
Copy link
Author

@unazko
We are using 16px as the basis of rem is SF applications. Just wonder if there is any standard about that only 14px font-size can be used as basis of rem in application with ui5-webcomponents?

unazko added a commit to unazko/ui5-webcomponents that referenced this issue Dec 16, 2022
- Component width is now 20rem as per visual specification.
This would result in not displaying a horizontal scrollbar
on 320px screen size.

Fixes: SAP#5641
@unazko
Copy link
Contributor

unazko commented Dec 16, 2022

Hi @zhangliangyi,

Apologies for the late response. I've got confused after many discussions on this topic.
There is no such standard indeed. We're going to fix the width of the calendar component now.

Best Regards,
Boyan

unazko added a commit that referenced this issue Dec 19, 2022
- Component width is now 20rem as per visual specification.
This would result in not displaying a horizontal scrollbar
on 320px screen size.

Fixes: #5641
Maintenance - Topic B automation moved this from In Progress to Completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

5 participants