feat(ui5-badge): add different design types #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorTaushanov
changed the title
packages/main/src/Badge.ts
Outdated
| @property({ type: ValueState, defaultValue: ValueState.None }) | ||
| valueState!: `${ValueState}`; | ||
|
|
||
| /** |
There was a problem hiding this comment.
can we combine this with colorScheme property. Both actually have colors from 1 to 10 and we can reuse the same enumeration?
| * @alias sap.ui.webc.main.types.BadgeDesignType | ||
| */ | ||
| enum BadgeDesignType { | ||
| /** |
There was a problem hiding this comment.
maybe ColorSet1, ColorSet2, ColorSet3 and ValueState or Semantic?
lets discuss in the meeting
packages/main/src/Badge.ts
Outdated
| * @public | ||
| */ | ||
| @property({ defaultValue: BadgeDesignType.ColorScheme }) | ||
| designType!: `${BadgeDesignType}`; |
There was a problem hiding this comment.
should we use just "design"? we already have "design" in other controls
BorisDafov
suggested changes
Dec 22, 2023
BorisDafov
reviewed
Dec 22, 2023
GerganaKremenska
requested changes
Jan 8, 2024
GerganaKremenska
approved these changes
Jan 9, 2024
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jan 17, 2024
* feat(ui5-badge): add different design types
kgogov
added a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.