Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-avatar: badge styles are broken #8491

Closed
1 task done
PetyaMarkovaBogdanova opened this issue Mar 21, 2024 · 0 comments · Fixed by #8564
Closed
1 task done

ui5-avatar: badge styles are broken #8491

PetyaMarkovaBogdanova opened this issue Mar 21, 2024 · 0 comments · Fixed by #8564
Assignees
@kgogov
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P

Comments

@PetyaMarkovaBogdanova
Copy link
Contributor

Bug Description

After a design feature, regarding ui5-badge is being merged, the styles of the badge in ui5-avatar are overwritten and need to be aligned with ui-avatar badge design spec.

Affected Component

ui5-avatar

Expected Behaviour

No response

Isolated Example

https://sap.github.io/ui5-webcomponents/storybook/playground/main/pages/Avatar/?sap-ui-theme=sap_horizon

Steps to Reproduce

Go to section "Avatar - Visual affordance"

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.23.1

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added the bug This issue is a bug in the code label Mar 21, 2024
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added this to Issues in Maintenance - Topic P via automation Mar 21, 2024
@kgogov kgogov self-assigned this Mar 21, 2024
@kgogov kgogov moved this from Issues to In Progress in Maintenance - Topic P Mar 21, 2024
@kgogov kgogov mentioned this issue Mar 28, 2024
Merged
Maintenance - Topic P automation moved this from In Progress to Completed Mar 29, 2024
kgogov added a commit that referenced this issue Mar 29, 2024
@kgogov
fix(ui5-avatar): correct badge style (#8564)
e3a373d 
This commit rectifies the badge alignment inside the avatar that was
disrupted after commit #7564. The badge is now properly aligned within
the avatar enhancing its visual appeal.

Fixes: #8491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgogov kgogov

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-avatar): correct badge style kgogov/ui5-webcomponents
2 participants
@PetyaMarkovaBogdanova @kgogov