Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][File Upload]: Mouse cursor was not displayed as clickable palm for mouseover #7794

Closed
1 task done
yuyuCream opened this issue Nov 3, 2023 · 4 comments · Fixed by SAP/ui5-webcomponents-react#5211 or #8485
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B

Comments

@yuyuCream
Copy link

yuyuCream commented Nov 3, 2023

Describe the bug

Mouse cursor was not displayed as clickable palm for mouseover

FileUpload.mov

Isolated Example

No response

Reproduction steps

  1. Navigate to UI5 Web Components for React
  2. Scroll to the bottom of the page
  3. Hover on the "Upload File", then you can find that mouse cursor was not displayed as clickable palm

Expected Behaviour

Mouse cursor should be displayed as clickable palm when hover on the "File Upload"

Screenshots or Videos

FileUpload.mov

UI5 Web Components for React Version

1.21.2

UI5 Web Components Version

1.21.2

Browser

Chrome

Operating System

mac

Additional Context

I am from SAP Successfactors and this issue has resulted in several customer incidents.

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@yuyuCream yuyuCream added the bug This issue is a bug in the code label Nov 3, 2023
@Lukas742 Lukas742 added documentation This issue is about wrong documentation and removed bug This issue is a bug in the code labels Nov 3, 2023
@Lukas742
Copy link
Collaborator

Lukas742 commented Nov 3, 2023

Hi @yuyuCream

there was only some CSS/props missing in the example, so this is not a bug with the component. The linked PR will remove the example, as it's not showing a typical use-case of the FileUploader.

@jiawang1
Copy link

jiawang1 commented Nov 3, 2023

hi @Lukas742 :

it is not the example missing css, but is the FileUploader. You can inspect the shadow DOM, the css property for the file element (input element with type file) is cursor: pointer does not work for chrome, the normal way is setting pseudo element. Like input[type="file"]::-webkit-file-upload-button { cursor:pointer; }...
Screenshot 2023-11-03 at 16 53 36

But when I check the pseudo element produced by the component, the cursor is default,
Screenshot 2023-11-03 at 17 04 02

So, no matter what kind of element I put under FileUploader, I can not make sure the cursor to pointer since the file element should on the upper layer to react to the user click event. And the only way to resolve this we have to write CSS into shadow DOM.

So please have a look to this component.

Regards
Jay

@Lukas742
Copy link
Collaborator

Lukas742 commented Nov 3, 2023

Hi @jiawang1

thanks for clarifying. I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi colleagues,
here you can find a codeSandbox using plain ui5wc showing the issue: https://codesandbox.io/s/ui5-webcomponents-forked-nknjcx?file=/index.html

@Lukas742 Lukas742 added bug This issue is a bug in the code and removed documentation This issue is about wrong documentation labels Nov 3, 2023
@Lukas742 Lukas742 reopened this Nov 3, 2023
@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Nov 3, 2023
@nnaydenow nnaydenow added this to New Issues in Maintenance - Topic B via automation Nov 8, 2023
@nnaydenow
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-b,

Could you please process the issue? Issue is reproducible in the storybook samples of ui5-webcomponents.

@unazko unazko self-assigned this Feb 29, 2024
@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B Mar 20, 2024
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Mar 20, 2024
Maintenance - Topic B automation moved this from In Progress to Completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B
Projects
7 participants