-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[checkbox]: mouse cursor and keypressed state for readonly checkbox #7807
Comments
Hello colleagues, Can you please check this issue? Best Regards, |
Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible. This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox. Fixes: SAP#7807
* fix(ui5-checkbox): improved key down behavior for readonly state Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible. This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox. Fixes: #7807
Hello @mhchem , Thanks for the issue. I checked some guidelines, emailed some of me colleagues and checked the OpenUI5 project as well. You can see this guideline here: Basically the element should be interactive but without the option to change its state. This is why I fixed only the "active" state on "Enter" or "Space" key down because it's quite misleading to indicate change of value. Regards, |
* fix(ui5-checkbox): improved key down behavior for readonly state Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible. This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox. Fixes: #7807
Bug Description
I think readonly checkboxes should neither show a "space pressed" state nor have a "klick me" mouse cursor on hover, because they are not interactive and cannot be changed.
Affected Component
No response
Expected Behaviour
No response
Isolated Example
No response
Steps to Reproduce
...
Log Output, Stack Trace or Screenshots
No response
Priority
None
UI5 Web Components Version
v1.19.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: