Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox]: mouse cursor and keypressed state for readonly checkbox #7807

Closed
1 task done
mhchem opened this issue Nov 6, 2023 · 2 comments · Fixed by #8226
Closed
1 task done

[checkbox]: mouse cursor and keypressed state for readonly checkbox #7807

mhchem opened this issue Nov 6, 2023 · 2 comments · Fixed by #8226
Assignees
Labels
bug This issue is a bug in the code TOPIC P

Comments

@mhchem
Copy link

mhchem commented Nov 6, 2023

Bug Description

I think readonly checkboxes should neither show a "space pressed" state nor have a "klick me" mouse cursor on hover, because they are not interactive and cannot be changed.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

v1.19.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@mhchem mhchem added the bug This issue is a bug in the code label Nov 6, 2023
@tsanislavgatev
Copy link
Contributor

Hello colleagues,

Can you please check this issue?
On space pressed there is a change of color and also cursor change on mouse hover.
https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-check-box--basic&args=readonly:!true

Best Regards,
Tsanislav

@tsanislavgatev tsanislavgatev added this to Issues in Maintenance - Topic P via automation Nov 7, 2023
@plamenivanov91 plamenivanov91 self-assigned this Jan 4, 2024
@plamenivanov91 plamenivanov91 moved this from Issues to In Progress in Maintenance - Topic P Jan 4, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Feb 2, 2024
Previously while holding "Space" or "Enter" key on a readonly checkbox
the "active" attribute was being applied on the checkbox main DOM node.
This was resulting in bluish tint over the readonly checkbox indicating
changing of value where this shouldn't be possible.

This wrong behavior is now fixed and "Space" or "Enter" keys down no
longer affect readonly checkbox.

Fixes: SAP#7807
Maintenance - Topic P automation moved this from In Progress to Completed Feb 2, 2024
plamenivanov91 added a commit that referenced this issue Feb 2, 2024
* fix(ui5-checkbox): improved key down behavior for readonly state

Previously while holding "Space" or "Enter" key on a readonly checkbox
the "active" attribute was being applied on the checkbox main DOM node.
This was resulting in bluish tint over the readonly checkbox indicating
changing of value where this shouldn't be possible.

This wrong behavior is now fixed and "Space" or "Enter" keys down no
longer affect readonly checkbox.

Fixes: #7807
@plamenivanov91
Copy link
Contributor

Hello @mhchem ,

Thanks for the issue.

I checked some guidelines, emailed some of me colleagues and checked the OpenUI5 project as well.

You can see this guideline here:
https://experience.sap.com/internal/fiori-design-web/ui-element-states/#read-only

Basically the element should be interactive but without the option to change its state.

This is why I fixed only the "active" state on "Enter" or "Space" key down because it's quite misleading to indicate change of value.

Regards,
Plamen Ivanov

tsanislavgatev pushed a commit that referenced this issue Feb 20, 2024
* fix(ui5-checkbox): improved key down behavior for readonly state

Previously while holding "Space" or "Enter" key on a readonly checkbox
the "active" attribute was being applied on the checkbox main DOM node.
This was resulting in bluish tint over the readonly checkbox indicating
changing of value where this shouldn't be possible.

This wrong behavior is now fixed and "Space" or "Enter" keys down no
longer affect readonly checkbox.

Fixes: #7807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants