Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Busy Indicator]: Theming Issue in Belize #7901

Closed
1 task done
mhchem opened this issue Nov 22, 2023 · 2 comments · Fixed by #8054
Closed
1 task done

[Busy Indicator]: Theming Issue in Belize #7901

mhchem opened this issue Nov 22, 2023 · 2 comments · Fixed by #8054
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@mhchem
Copy link

mhchem commented Nov 22, 2023

Bug Description

The Busy Indicator does not have the right appearance in the Belize theme.
This is very visible when having UI5 and UI5 Web Components in the same application.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

Compare

(Also, the sizes differ. And the animation differs slightly: With UI5, there is a moment when all 3 bubbles are the same size, but this does not happen for Web Components. But most important is the color difference.)

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

Demo Kit 1.120

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@mhchem mhchem added the bug This issue is a bug in the code label Nov 22, 2023
@MapTo0 MapTo0 added this to New Issues in Maintenance - Topic RL via automation Nov 23, 2023
@MapTo0
Copy link
Member

MapTo0 commented Nov 23, 2023

Hi, Team,

Belize issue for the Busy Indicator, please have a look.

Regards,
Martin

@georgimkv georgimkv removed this from New Issues in Maintenance - Topic RL Nov 23, 2023
@georgimkv georgimkv added this to New Issues in Maintenance - Topic RD via automation Nov 23, 2023
@s-todorova s-todorova self-assigned this Jan 2, 2024
s-todorova added a commit that referenced this issue Jan 4, 2024
The busy indicator should look and behave the same way as its UI5 counterpart,
in terms of color and animation for Belize theme.

Fixes: #7901
Maintenance - Topic RD automation moved this from New Issues to Completed Jan 10, 2024
@s-todorova
Copy link
Contributor

Hello @mhchem,

The difference in color has been fixed.

However, support for the Belize theme has been deprecated for ui5 and Web Components will soon follow. Therefore, after consideration it was decided that further adjustments to the animation/size difference would require more effort than appropriate, considering the upcoming deprecation of support for Belize theme.

We strongly suggest updating to Horizon theme.

Best regards,
Siyana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Status: Completed
4 participants