Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-side-navigation]: Not customizable after upgrade to 1.20.0 #7982

Closed
1 task done
kozubikmichal opened this issue Dec 8, 2023 · 1 comment · Fixed by #8081
Closed
1 task done

[ui5-side-navigation]: Not customizable after upgrade to 1.20.0 #7982

kozubikmichal opened this issue Dec 8, 2023 · 1 comment · Fixed by #8081
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC RD

Comments

@kozubikmichal
Copy link

Bug Description

After upgrade to the web components v1.20.0, we lost the customization options for the Side Navigation component, which introduced 2 issues in our product:

  1. New version provides less space for the text and does not support changing of the width anymore -> some of our texts are now broken into multiple lines. Setting the width CSS property does not work (was working before this update)
  2. Border radius cannot be changed again (was fixed it [ui5-side-navigation]: Forced top border radius in Side Navigation #7308, after upgrade it's not working anymore)

As working with the codesandbox is not good on SAP enrolled devices, feel free to contact me via corporate communication channels and I can provide you more details.

image

With highlighted element:
image

Affected Component

Side Navigation

Expected Behaviour

  1. Space for the texts should remain the same OR there should be an option how to adjust it (eg. width property)
  2. Rounded corners should not be mandatory, as it was in previous version (border-radius property)

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.20.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@kozubikmichal kozubikmichal added the bug This issue is a bug in the code label Dec 8, 2023
@petyabegovska petyabegovska added the SAP Signavio SAP Signavio label Dec 8, 2023
@unazko unazko added this to New Issues in Maintenance - Topic RD via automation Dec 8, 2023
@unazko
Copy link
Contributor

unazko commented Dec 8, 2023

Hello @SAP/ui5-webcomponents-topic-rd,

Tested at the following URL:
https://sap.github.io/ui5-webcomponents/playground/?path=/story/fiori-side-navigation--basic

Indeed the border-radius and width aren't customizable.

Please have a look.

Best regards,
Boyan

Maintenance - Topic RD automation moved this from New Issues to Completed Jan 19, 2024
alexandar-mitsev added a commit that referenced this issue Apr 5, 2024
Removed rounded corners and shadow from ui5-side-navigation.
Now it can be visually combined with other components in the framework.

Related to: #7982, #7308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants