Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover: footer is not positioned correctly if a height is applied #8009

Closed
1 task done
Lukas742 opened this issue Dec 15, 2023 · 1 comment · Fixed by #8180
Closed
1 task done

Popover: footer is not positioned correctly if a height is applied #8009

Lukas742 opened this issue Dec 15, 2023 · 1 comment · Fixed by #8180
Assignees
@LidiyaGeorgieva
Labels
bug This issue is a bug in the code Low Prio TOPIC RD UI5_WEBC_4_REACT
Projects
Maintenance - Topic RD

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Dec 15, 2023 •
edited
Loading

Bug Description

The Popover and ResponsivePopover don't position the footer correctly if a height is applied to the popover.

Affected Component

probably all popover components

Expected Behaviour

Even with fixed height, the footer should be positioned at the bottom of the popover.

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-dsg8rl?file=/index.html

Steps to Reproduce

  1. Go to codeSandbox
  2. Open one of the popovers that have a fixed height
  3. See that the footer is misaligned

Log Output, Stack Trace or Screenshots

image

Priority

None

UI5 Web Components Version

1.20.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

UI5 Web Components for React

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug This issue is a bug in the code label Dec 15, 2023
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Dec 15, 2023
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added this to New Issues in Maintenance - Topic RD via automation Dec 15, 2023
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi team,
can you, please, take a look at the position of ui5-responsive-popover, when height is set?
Best regards,
Petya Markova.
(UI5 WC Developer)

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Dec 15, 2023
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Jan 24, 2024
LidiyaGeorgieva added a commit that referenced this issue Jan 25, 2024
@LidiyaGeorgieva
fix(ui5-popover): correct position of the footer
0acebb8 
When there is height set on the popover
the footer should be positioned on the bottom
of the popover.

Fixes: #8009
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Jan 25, 2024
Merged
Maintenance - Topic RD automation moved this from New Issues to Completed Jan 25, 2024
LidiyaGeorgieva added a commit that referenced this issue Jan 25, 2024
@LidiyaGeorgieva
fix(ui5-popover): correct position of the footer (#8180)
a5a2f8b 
When there is height set on the popover
the footer should be positioned on the bottom
of the popover.

Fixes: #8009
tsanislavgatev pushed a commit that referenced this issue Feb 20, 2024
@LidiyaGeorgieva @tsanislavgatev
fix(ui5-popover): correct position of the footer (#8180)
f7e4000 
When there is height set on the popover
the footer should be positioned on the bottom
of the popover.

Fixes: #8009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
bug This issue is a bug in the code Low Prio TOPIC RD UI5_WEBC_4_REACT
Projects
Maintenance - Topic RD
Status: Completed
Maintenance - Topic RD
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-popover): correct position of the footer SAP/ui5-webcomponents
4 participants
@LidiyaGeorgieva @petyabegovska @Lukas742 @PetyaMarkovaBogdanova