Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-shellbar]: logo button Horizon style #8058

Closed
1 task done
JarrettChan opened this issue Jan 8, 2024 · 2 comments · Fixed by #8109
Closed
1 task done

[ui5-shellbar]: logo button Horizon style #8058

JarrettChan opened this issue Jan 8, 2024 · 2 comments · Fixed by #8109
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P

Comments

@JarrettChan
Copy link

JarrettChan commented Jan 8, 2024

Bug Description

Per the Horizon VD wiki ShellBar specs

Image Button (Logo) Follows the button behaviour.
  1. The logo button is probably meant to be styled like a tertiary button, but there are a couple issues
    1. The logo button is rendered with square corners in default state.
    2. The logo button hover border and focus border overlap the logo instead of clipping it.
  2. The logo is missing additional 0.25rem padding on the left/right to mitigate the Horizon rounded corners.

Affected Component

ui5-shellbar

Expected Behaviour

Add the 0 0.25rem padding to ::slotted([slot="logo"]) in Horizon
Address the hover border and focus border clipping
Logo button always have rounded corners in Horizon

Isolated Example

No response

Steps to Reproduce

  1. https://sap.github.io/ui5-webcomponents/playground/?path=/story/fiori-shellbar--basic
  2. tab into the logo
  3. Observe: focus border is overlapping the logo

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.21.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@JarrettChan JarrettChan added the bug This issue is a bug in the code label Jan 8, 2024
@petyabegovska
Copy link
Collaborator

Hi @JarrettChan, please don't put internal links as it is an external Github. You can replace the links of the Shell bar wiki page with: "Shellbar Horizon VD wiki" as a text.

Thanks and best regards,
Petya

@kgogov kgogov added this to Issues in Maintenance - Topic P via automation Jan 9, 2024
@kgogov
Copy link
Member

kgogov commented Jan 9, 2024

Hi @JarrettChan,

Thank you for reaching out.
Our team will look into your concerns and get back to you soon.


Hi @SAP/ui5-webcomponents-topic-p,

Based on the information provided by the reporter it appears that the logo button needs additional styles alignment.
You can observe the problem in this sample.

Could you please take a look?

Best regards,
Konstantin

@plamenivanov91 plamenivanov91 self-assigned this Jan 9, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Jan 15, 2024
The logo now has small gap between itself and its focus/hover outline
in order to avoid overlap.
Fixes: SAP#8058
plamenivanov91 added a commit that referenced this issue Jan 15, 2024
The logo now has small gap between itself and its focus/hover outline
in order to avoid overlap.
Fixes: #8058
Maintenance - Topic P automation moved this from Issues to Completed Jan 15, 2024
PetyaMarkovaBogdanova pushed a commit that referenced this issue Jan 17, 2024
The logo now has small gap between itself and its focus/hover outline
in order to avoid overlap.
Fixes: #8058
tsanislavgatev pushed a commit that referenced this issue Feb 20, 2024
The logo now has small gap between itself and its focus/hover outline
in order to avoid overlap.
Fixes: #8058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants