Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-li-notification-group expand button #8059

Closed
1 task done
arifunlu opened this issue Jan 8, 2024 · 1 comment · Fixed by #8166
Closed
1 task done

ui5-li-notification-group expand button #8059

arifunlu opened this issue Jan 8, 2024 · 1 comment · Fixed by #8166
Assignees
@LidiyaGeorgieva
Labels
bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD

Comments

@arifunlu
Copy link

arifunlu commented Jan 8, 2024

Bug Description

The expand-collapse button also changes its shape when expanded or collapsed.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.21.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@arifunlu arifunlu added the bug This issue is a bug in the code label Jan 8, 2024
@kgogov
Copy link
Member

kgogov commented Jan 9, 2024

Hi @arifunlu,

Thank you for reaching out.
Our team will look into your concern and get back to you soon.

Hello @SAP/ui5-webcomponents-topic-rd,

I've noticed a visual difference in the shape of a button when it's expanded/collapsed in a live example from our documentation. Could you please take a look?

Best regards,
Konstantin

Screenshot 2024-01-09 at 14 41 50 Screenshot 2024-01-09 at 14 42 00

@kgogov kgogov added the TOPIC RD label Jan 9, 2024
@kgogov kgogov added this to New Issues in Maintenance - Topic RD via automation Jan 9, 2024
@kgogov kgogov added the Low Prio label Jan 9, 2024
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Jan 23, 2024
LidiyaGeorgieva added a commit that referenced this issue Jan 23, 2024
@LidiyaGeorgieva
fix(ui5-li-notification-group): correct collapse button shape on Comp…
c80842c 
…act mode

The button should not chanage its shape when clicked.

Fixes #8059
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Jan 23, 2024
Merged
Maintenance - Topic RD automation moved this from New Issues to Completed Jan 25, 2024
LidiyaGeorgieva added a commit that referenced this issue Jan 25, 2024
@LidiyaGeorgieva
fix(ui5-li-notification-group): correct collapse button shape on Comp…
226d975 
…act mode (#8166)

The button should not chanage its shape when clicked.

Fixes #8059
tsanislavgatev pushed a commit that referenced this issue Feb 20, 2024
@LidiyaGeorgieva @tsanislavgatev
fix(ui5-li-notification-group): correct collapse button shape on Comp…
745ae3d 
…act mode (#8166)

The button should not chanage its shape when clicked.

Fixes #8059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Maintenance - Topic RD
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-li-notification-group): correct collapse button shape on Compact mode SAP/ui5-webcomponents
3 participants
@arifunlu @LidiyaGeorgieva @kgogov