Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextArea]: Large Text Inside Text Area Resizes the Page #8082

Closed
1 task done
m1trix opened this issue Jan 10, 2024 · 2 comments · Fixed by #8118
Closed
1 task done

[TextArea]: Large Text Inside Text Area Resizes the Page #8082

m1trix opened this issue Jan 10, 2024 · 2 comments · Fixed by #8118
Assignees
Labels
Autopilot bug This issue is a bug in the code Medium Prio TOPIC RL

Comments

@m1trix
Copy link

m1trix commented Jan 10, 2024

Bug Description

When a ui5-textarea is being used with the growing property set to true and the text within the component is taller than the textarea itself (e.g. has a lot of lines) the text itself is cut-off by the border of the textarea but the height of the page gets increased as if the text itself is placed outside of the textarea.

Details

Tested on https://sap.github.io/ui5-webcomponents-react

Setup

  • rows = 4
  • growing = true
  • growingMaxLines = 5
  • value = the numbers from 1 to 200, each on a new line

It looks like that setting growing=true breaks the component.

Affected Component

ui5-textarea

Expected Behaviour

The page should not resize, similar to how a native textarea HTML component does not affect the page it is placed in, when its content's height exceeds its own height.

Isolated Example

Link to Code Sandbox

Steps to Reproduce

  1. Have a UI5 TextArea with rows = 4, growing = true, growingMaxLines = 5
  2. Input a text that is taller than the page (e.g. numbers from 1 to 500)
  3. Observe how the page itself gets extended in height.

Log Output, Stack Trace or Screenshots

image

Priority

Medium

UI5 Web Components Version

1.19.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@m1trix m1trix added the bug This issue is a bug in the code label Jan 10, 2024
@kgogov kgogov self-assigned this Jan 10, 2024
@kgogov
Copy link
Member

kgogov commented Jan 12, 2024

Hello @m1trix,

Thanks for reaching out to us, our team will review your report shortly.

Best,
Konstantin

@kgogov
Copy link
Member

kgogov commented Jan 12, 2024

Hello @SAP/ui5-webcomponents-topic-rl,

After reviewing the reported issue with the ui5-textarea component, it seems that in this case, there is a problem with using the growing property. Please, refer to this CodeSandbox the author has provided.

Could you take a look?

Best,
Konstantin

@kgogov kgogov added this to New Issues in Maintenance - Topic RL via automation Jan 12, 2024
@kgogov kgogov removed their assignment Jan 12, 2024
@ndeshev ndeshev self-assigned this Jan 15, 2024
ndeshev added a commit that referenced this issue Jan 15, 2024
@niyap niyap moved this from New Issues to In progress in Maintenance - Topic RL Jan 16, 2024
ndeshev added a commit that referenced this issue Jan 18, 2024
Maintenance - Topic RL automation moved this from In progress to Completed Jan 18, 2024
ilhan007 pushed a commit that referenced this issue Jan 19, 2024
ilhan007 pushed a commit that referenced this issue Jan 25, 2024
tsanislavgatev pushed a commit that referenced this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autopilot bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants