feat(ui5-datetime-picker): replace time part wheelsliders with clocks #8129
Conversation
NHristov-sap
requested review from
tsanislavgatev,
vladitasev,
nnaydenow and
ilhan007
packages/main/src/DateTimePicker.ts
Outdated
| @@ -210,9 +203,8 @@ class DateTimePicker extends DatePicker { | |||
| * @public | |||
| */ | |||
| async openPicker(): Promise<void> { | |||
| await super.openPicker(); | |||
| this._currentTimeSlider = "hours"; | |||
| this._previewValues.timeSelectionValue = this.value || this.getFormat().format(new Date()); | |||
There was a problem hiding this comment.
also please check _calendarSelectedDates and _calendarTimestamp. Seems that the fallback is always executed and the overrides seems to be redundant.
There was a problem hiding this comment.
the mentioned getters _calendarSelectedDates and _calendarTimestamp are necessary, you can check it by commenting them and try to use a picker when there is no date selected already.
There was a problem hiding this comment.
this._previewValues. _calendarSelectedDates is never set so we always use the value which comes from the parent class. Take this as possible cleanup in separate PR
There was a problem hiding this comment.
It is set in the onSelectedDatesChange method
There was a problem hiding this comment.
UPDATE: Ignore that comment. We've discussed it offline and the popover should be opened on the view where it was closed.
Also I think that I found an issue with the popover. Could you please confirm it?
When the popover is opened for first time the time picker starts from "hours" view and after that it starts from the "seconds" view.
If it's a issue could you please it here or to open separate issue so we can track the progress?
Screen.Recording.2024-01-31.at.15.17.45.mov
|
Fixes #7802 |
…#8129) * feat(ui5-datetime-picker): replace time part wheelsliders with clocks * feat(ui5-datetime-picker): fix comments * feat(ui5-datetime-picker): fix more comments * feat(ui5-datetime-picker): remove redundant getter * feat(ui5-datetime-picker): adjust mobile view * feat(ui5-datetime-picker): fix code reordering in openPicker method
Some time ago the ui5-time-picker component was redesigned to use clock dials instead of wheel sliders, but ui5-datetime-picker component wasn't redesigned too.
This PR introduces change of time part - now it also uses clock dials instead of wheel sliders.