fix(ui5-checkbox): improved key down behavior for readonly state #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible. This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox. Fixes: SAP#7807
plamenivanov91
requested review from
kineticjs,
IlianaB,
PetyaMarkovaBogdanova,
dobrinyonkov,
yanaminkova and
kgogov
kgogov
reviewed
Feb 2, 2024
- improved test page
- fixed false positive testing
kgogov
approved these changes
Feb 2, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix(ui5-checkbox): improved key down behavior for readonly state Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible. This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox. Fixes: #7807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously while holding "Space" or "Enter" key on a readonly checkbox the "active" attribute was being applied on the checkbox main DOM node. This was resulting in bluish tint over the readonly checkbox indicating changing of value where this shouldn't be possible.
This wrong behavior is now fixed and "Space" or "Enter" keys down no longer affect readonly checkbox.
Fixes: #7807