fix(ui5-progress-indicator): hidden value design

[PetyaMarkovaBogdanova]

Component padding reduced in case with hidden value.

[ilhan007]

For the other themes, this parameter --_ui5_progress_indicator_padding_novalue won't exist and basically it will be padding-top: undefined.

Even if this works and does not cause issue in the other themes, if we follow this pattern to only define variables for the themes they were initially required, soon it will get difficult to maintain the css params, because some of them will be defined only in these themes, some of them only in these themes.

That's why so far we used to define the variables always by adding them to the base params with some default value that is fine for most of the themes, and then overwrite them where needed (in this case sap_horizon, would not be also needed in sap_horizon_dark - they are usually pretty close in padding/margins). This way when you see a parameter, it's guaranteed to exist in all themes and you won't need to track it down and see where it comes from.

[PetyaMarkovaBogdanova]

For the other themes, this parameter --_ui5_progress_indicator_padding_novalue won't exist and basically it will be padding-top: undefined.

Even if this works and does not cause issue in the other themes, if we follow this pattern to only define variables for the themes they were initially required, soon it will get difficult to maintain the css params, because some of them will be defined only in these themes, some of them only in these themes.

That's why so far we used to define the variables always by adding them to the base params with some default value that is fine for most of the themes, and then overwrite them where needed (in this case sap_horizon, would not be also needed in sap_horizon_dark - they are usually pretty close in padding/margins). This way when you see a parameter, it's guaranteed to exist in all themes and you won't need to track it down and see where it comes from.

Thanks, Ilhan, for the informative remark.

[ilhan007]

last check: should not we also add the --_ui5_progress_indicator_padding_novalue: 0.3125rem; int sap_horizon_dark?

[PetyaMarkovaBogdanova]

last check: should not we also add the --_ui5_progress_indicator_padding_novalue: 0.3125rem; int sap_horizon_dark?

Horizon_dark theme seems to inherit parameters for ProgressIndicator from the main horizon theme (which imports also layout parameters), so for now I do not see the need to add it there also.

[ilhan007]

Checked the case - it works in sap_horizon_dark without any additional changes, because in the sap_horizon_dark/parameters-bundle.css you are basically importing the sap_horizon params:

// sap_horizon_dark/parameters-bundle.css
@import "../sap_horizon/ProgressIndicator-parameters.css";

Although this is the only case done like this (only the ProgressIndicator) - it's fine to remain as it is. So no action items in that regards.

---

One unrelated type that I found accidentally why looking into the change (could be fixed in a separate change I don't mind),

I noticed this variable usage in the ProgressIndicator.css (line 3) while reviewing this change:
min-height: var(_ui5_progress_indicator_host_min_height); without the -- in front,

it should be:
min-height: var(--_ui5_progress_indicator_host_min_height);