Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-shellbar]: ui5-icon is missing scoping #8609

Closed
1 task done
JarrettChan opened this issue Apr 2, 2024 · 0 comments · Fixed by #8613
Closed
1 task done

[ui5-shellbar]: ui5-icon is missing scoping #8609

JarrettChan opened this issue Apr 2, 2024 · 0 comments · Fixed by #8613
Assignees
Labels
bug This issue is a bug in the code

Comments

@JarrettChan
Copy link

Bug Description

ui5-icon is not scoped in menu button
image

dependencies: [
Button,
List,
Popover,
StandardListItem,
],

add Icon to scoping dependencies

Affected Component

ui5-shellbar

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.23.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@JarrettChan JarrettChan added the bug This issue is a bug in the code label Apr 2, 2024
@nnaydenow nnaydenow self-assigned this Apr 3, 2024
ilhan007 pushed a commit that referenced this issue Apr 3, 2024
Icons used inside ui5-shellbar's template are not scoped because ui5-icon is not described as dependency of it. In addition slim-arrow-down is imported otherwise it wasn't loaded.

Fixes: #8609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
2 participants