[ui5-side-navigation / ui5-tab-container]: wrong slot type definition #8698
Assignees
Labels
Projects
Comments
dimovpetar
added a commit
that referenced
this issue
Apr 11, 2024
dimovpetar
added a commit
that referenced
this issue
Apr 11, 2024
…h SideNavigationItemBase Related to: #8698
alexandar-mitsev
pushed a commit
that referenced
this issue
Apr 12, 2024
dimovpetar
added a commit
that referenced
this issue
Apr 26, 2024
…h SideNavigationItemBase Related to: #8698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
If we need to describe slot with a union type like
Array<Class1 | Class2>, we typically replace the union type with an interface that both classes implement. Using this union type syntax can create an incorrect custom-elements.json, which is essential for building wrappers for OpenUI5 / ui5-web-components-react. We use this interface because it can't be constructed by tools during the wrapper generation phase.https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/src/Tab.ts#L188
https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/src/TabContainer.ts#L291
https://github.com/SAP/ui5-webcomponents/blob/main/packages/fiori/src/SideNavigation.ts#L152
Affected Component
ui5-side-navigation / ui5-tab-container
UI5 Web Components Version
latest
The text was updated successfully, but these errors were encountered: