Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tabcontainer): replace default slot union type with interface #8734

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

dimovpetar
Copy link
Contributor

Related to: #8698

@dimovpetar dimovpetar changed the title fix(ui5-tabcontainer): replace default slot union union with interface fix(ui5-tabcontainer): replace default slot union type with interface Apr 11, 2024
Copy link
Contributor

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • also do the change for Tab.ts slot items, currently it is still items!: Array<Tab | TabSeparator>

packages/main/src/TabContainer.ts Show resolved Hide resolved
@dimovpetar
Copy link
Contributor Author

  • also do the change for Tab.ts slot items, currently it is still items!: Array<Tab | TabSeparator>

Done

@alexandar-mitsev alexandar-mitsev merged commit ac6b44f into main Apr 12, 2024
9 checks passed
@alexandar-mitsev alexandar-mitsev deleted the replace_tc_union_with_interface branch April 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants