ui5-menu: runtime error

[vladitasev]

Bug Description

1.Run the project locally

2. Click "Open Menu" -> Open -> Open Locally -> Open from C

3. There is a runtime error

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

High

UI5 Web Components Version

2.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

• I’m not disclosing any internal or sensitive information.

[vladitasev]

@unazko @tsanislavgatev Please have a look

I debugged a bit. When the error occurs:

I manually followed the DOM and found out that:

Basically, when I find the "Open from local" item in the DOM and click it ($0) I can confirm that this is not the same DOM element as the one in the expression, therefore the code breaks.

[unazko]

Hello @vladitasev,

This issue only happens as the busy state of the ui5-menu-item is broken after changing the names of the busy and busyDelay properties to loading and loadingDelay in the ui5-list. I suspect that we open the sub-menu from the current item. Later the same item gets re-rendered after two additional items are being added so it's a different item than the one from which we've opened the menu.

The same issue isn't reproducible via the following PR: #8722
I'll take only the needed part from the PR as it is a more major refactoring.

Best regards,
Boyan

[vladitasev]

Thanks for the quick fix! I've approved the PR.

When the colleagues merged the change to ui5-list (renaming of these properties) all menu tests were still passing, meaning there's no test covering the usage of this property. This is something to be improved in the future.