We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the popover component inside the shellbar appears to look more like a menu/menuitem but is assigned the role of dialog. https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/
ui5-popover & ui5-shellbar
The ask is change role of dialog to role of menu and make the list items inside role of menuitem. https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/
https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area
No response
Medium
1.24.0
Chrome
SAP SuccessFactors
The text was updated successfully, but these errors were encountered:
Hello @ui5-webcomponents-topic-p,
I am forwarding this issue to you, please check the reported issue.
Best Regards, Nikolay Hristov UI5 WebC Dispatcher
Sorry, something went wrong.
fix(ui5-shellbar): improved samples accessibility
bb28ebd
Additional acc roles are added to the profile button's popover. Fixes: SAP#8821
fix(ui5-shellbar): improved samples accessibility (#8847)
7563e7d
Additional acc roles are added to the profile button's popover. Fixes: #8821
plamenivanov91
Successfully merging a pull request may close this issue.
Bug Description
Using the popover component inside the shellbar appears to look more like a menu/menuitem but is assigned the role of dialog.
![Screenshot 2024-04-22 at 2 56 44 PM](https://private-user-images.githubusercontent.com/167583724/324624056-ef908b2a-85a4-48a5-a61f-b51aac70d15a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxODE3MTgsIm5iZiI6MTcyMDE4MTQxOCwicGF0aCI6Ii8xNjc1ODM3MjQvMzI0NjI0MDU2LWVmOTA4YjJhLTg1YTQtNDhhNS1hNjFmLWI1MWFhYzcwZDE1YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwNVQxMjEwMThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yOTBmNzhkZDk3Yjc4MzI5OWUyNTMwMDVjYzdiZGQ4OGQ5OTJjZjVlZWVjMTdkYzQzNWRmOTA1ZGQ1ZjU1ZThhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.S8Sq8JWI968O29c8sF4A9wAjQCv7MM4cUo-xlPNcnig)
https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/
Affected Component
ui5-popover & ui5-shellbar
Expected Behaviour
The ask is change role of dialog to role of menu and make the list items inside role of menuitem.
https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/
Isolated Example
https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area
Steps to Reproduce
Log Output, Stack Trace or Screenshots
No response
Priority
Medium
UI5 Web Components Version
1.24.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Organization
SAP SuccessFactors
Declaration
The text was updated successfully, but these errors were encountered: