Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][a11y][ui5-popover]: ui5 popover component inside shellbar role should be menu with menu items #8821

Closed
1 task done
lormanlau1 opened this issue Apr 22, 2024 · 1 comment · Fixed by #8847
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC P

Comments

@lormanlau1
Copy link

Bug Description

Using the popover component inside the shellbar appears to look more like a menu/menuitem but is assigned the role of dialog.
https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/
Screenshot 2024-04-22 at 2 56 44 PM

Affected Component

ui5-popover & ui5-shellbar

Expected Behaviour

The ask is change role of dialog to role of menu and make the list items inside role of menuitem.
https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/

Isolated Example

https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area

Steps to Reproduce

  1. navigate to https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area
  2. click on the profile button to show popover
  3. observe that the popover has the role dialog

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@lormanlau1 lormanlau1 added the bug This issue is a bug in the code label Apr 22, 2024
@NHristov-sap NHristov-sap added this to Issues in Maintenance - Topic P via automation Apr 23, 2024
@NHristov-sap
Copy link
Contributor

Hello @ui5-webcomponents-topic-p,

I am forwarding this issue to you, please check the reported issue.

Best Regards,
Nikolay Hristov
UI5 WebC Dispatcher

@plamenivanov91 plamenivanov91 self-assigned this Apr 25, 2024
@plamenivanov91 plamenivanov91 moved this from Issues to In Progress in Maintenance - Topic P Apr 25, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Apr 25, 2024
Additional acc roles are added to the profile button's popover.

Fixes: SAP#8821
plamenivanov91 added a commit that referenced this issue Jun 6, 2024
Additional acc roles are added to the profile button's popover.

Fixes: #8821
Maintenance - Topic P automation moved this from In Progress to Completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants