Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): improved samples accessibility #8847

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

plamenivanov91
Copy link
Contributor

Additional acc roles are added to the profile button's popover.

Fixes: #8821

Additional acc roles are added to the profile button's popover.

Fixes: SAP#8821
@yanaminkova
Copy link
Member

I suggest maintaining the current role for now, since the accessibility specification is not explicit about what it should be.
You can suggest to the reporter that if their request is urgent, they could specify the roles themselves, as you have already done in this change. Additionally, consider lowering the priority of the ticket.
Meanwhile, we can consult with the accessibility expert responsible for the screen reader specification and if we obtain their agreement and once the specification is updated, we can proceed to update the sample accordingly.

@yanaminkova
Copy link
Member

Following consultation with the accessibility expert responsible for the screen reader specification, it has been determined that the correct approach in this scenario is to adjust the accessible-role of the ui5-popover containing the list to "None." Currently, it retains its default role as "Dialog," which is unsuitable for containing a menu.
Consequently, the ui5-list and the ui5-li should be appropriately designated as "menu" and "menuitem," as you have already done.

@plamenivanov91 plamenivanov91 merged commit 7563e7d into SAP:main Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][a11y][ui5-popover]: ui5 popover component inside shellbar role should be menu with menu items
2 participants