Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Illustrative Message Component]: description (body text) using wrong color parameter #8984

Closed
1 task done
ShirSAP opened this issue May 16, 2024 · 2 comments · Fixed by #8986
Closed
1 task done
Labels
bug This issue is a bug in the code Low Prio TOPIC P

Comments

@ShirSAP
Copy link

ShirSAP commented May 16, 2024

Bug Description

Today the description (body text) is using "--sapContent_LabelColor" color parameter.

Affected Component

https://sap.github.io/ui5-webcomponents-react/?path=/docs/user-feedback-illustratedmessage--docs

Expected Behaviour

we should use "color: --sap_TextColor;" instead.
This is specified in the following wiki: https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=3139378128

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

1.18.0

Browser

Chrome

Operating System

OS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ShirSAP ShirSAP added the bug This issue is a bug in the code label May 16, 2024
@ShirSAP ShirSAP changed the title [Illustrative Message description (body text) using wrong color parameter]: [Illustrative Message Component]: description (body text) using wrong color parameter May 16, 2024
@GerganaKremenska GerganaKremenska self-assigned this May 16, 2024
@GerganaKremenska GerganaKremenska added this to Issues in Maintenance - Topic P via automation May 16, 2024
@GerganaKremenska
Copy link
Member

Hello @ui5-webcomponents-topic-p I am forwarding this issue to you,
because there is a diviation from the parameter given in the VD specifcation and the one set to the description text of the illustrated message.

Best Regards,
Gergana

@GerganaKremenska GerganaKremenska removed their assignment May 16, 2024
ilhan007 added a commit that referenced this issue May 16, 2024
The specs have been updated and now the subtitle color should use --sapTextColor variable, instead of --sapContent_LabelColor.

Fixes: #8984
Maintenance - Topic P automation moved this from Issues to Completed May 16, 2024
ilhan007 added a commit that referenced this issue May 16, 2024
The specs have been updated and now the subtitle color should use --sapTextColor variable, instead of --sapContent_LabelColor.

Fixes: #8984
@ilhan007
Copy link
Member

ilhan007 commented May 16, 2024

Hello @ShirSAP the issue has been fixed
and will be available with:
1.24.X - start of June
2.0.0-rc.X - start of June

The fix can be seen on the nightly deployment https://sap.github.io/ui5-webcomponents/nightly/components/fiori/IllustratedMessage/#illustratedmessage-in-dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants