Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideNavigation]: wholeItemToggleable attribute does not work in Firefox #9057

Closed
1 task done
martinpriputen opened this issue May 23, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Milestone

Comments

@martinpriputen
Copy link

Bug Description

There seems to be an issue with SideNavigation component. After enabling property wholeItemToggleable in SideNavigationItem component, clicking on the whole node should expand the sub item. This is true for Edge and Chrome browsers but doesn't seem to work in Firefox. In Firefox even if the property is enabled, only clicking on arrow expands the node. Clicking elsewhere on the node adds blue dot, but doesn't expand the node.

Affected Component

No response

Expected Behaviour

If wholeItemToggleable attribute is added to SideNavigationItem, the navigation node should be expanded when clicking anywhere on the node in Firefox

Isolated Example

No response

Steps to Reproduce

  1. define Side Navigation component:
<SideNavigation>
    <SideNavigationItem wholeItemToggleable text="Test">
        <SideNavigationSubItem text="Test Sub 1"></SideNavigationSubItem>
    </SideNavigationItem>
</SideNavigation>
  1. test the component in Firefox.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

~1.24.0

Browser

Firefox

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@martinpriputen martinpriputen added the bug This issue is a bug in the code label May 23, 2024
@Todor-ads Todor-ads added this to New Issues in Maintenance - Topic RD via automation May 26, 2024
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rd ,

Please take a look at this reproducible issue.
Best regards,
Todor

@LidiyaGeorgieva
Copy link
Contributor

Hello @martinpriputen , do you plan to use ui5-webcomponents 2.0 version soon?

LidiyaGeorgieva added a commit that referenced this issue Jun 10, 2024
BREAKING CHANGE: the `wholeItemToggleAble` poperty of `ui5-side-navigation-item` is now remomoved.
The functionality of clicking the whole item to show/hide the sub items (if present) will
be introduced soon with new property name and enhanced accessibility and keyboard handling.

Related to #9057
LidiyaGeorgieva added a commit that referenced this issue Jun 11, 2024
…9153)

event.pointerType is not supported in FireFox browser, therefore the
check if event is with mouse is changed to check if the action is done in desktop

Fixes: #9057
@LidiyaGeorgieva
Copy link
Contributor

Hello @martinpriputen , the reported issue is fixed for ui5-webcomponents version 1.24.

Maintenance - Topic RD automation moved this from New Issues to Completed Jun 11, 2024
LidiyaGeorgieva added a commit that referenced this issue Jun 12, 2024
…ty (#9164)

refactor(ui5-side-navigation-item): delete wholeItemToggleAble poperty

BREAKING CHANGE: the `wholeItemToggleAble` poperty of `ui5-side-navigation-item` is now remomoved.
The functionality of clicking the whole item to show/hide the sub items (if present) will
be introduced soon with new property name and enhanced accessibility and keyboard handling.

Related to #9057
ilhan007 pushed a commit that referenced this issue Jun 14, 2024
…ty (#9164)

refactor(ui5-side-navigation-item): delete wholeItemToggleAble poperty

BREAKING CHANGE: the `wholeItemToggleAble` poperty of `ui5-side-navigation-item` is now remomoved.
The functionality of clicking the whole item to show/hide the sub items (if present) will
be introduced soon with new property name and enhanced accessibility and keyboard handling.

Related to #9057
kgogov pushed a commit that referenced this issue Jun 17, 2024
…ty (#9164)

refactor(ui5-side-navigation-item): delete wholeItemToggleAble poperty

BREAKING CHANGE: the `wholeItemToggleAble` poperty of `ui5-side-navigation-item` is now remomoved.
The functionality of clicking the whole item to show/hide the sub items (if present) will
be introduced soon with new property name and enhanced accessibility and keyboard handling.

Related to #9057
@ilhan007 ilhan007 added this to the 1.24.5 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Status: Completed
Development

No branches or pull requests

5 participants