Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-segmentedbutton): button can no longer be clicked when disabled #1393

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

ivoplashkov
Copy link
Member

FIXES: #1382

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have extracted event.target to a var on top as it is used several times, but it's fine, very minor comment nonetheless

@vladitasev vladitasev merged commit 576d769 into SAP:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diabled segmented button can be clicked
2 participants