Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-date-picker): rename component #1801

Merged
merged 4 commits into from
Jun 18, 2020
Merged

chore(ui5-date-picker): rename component #1801

merged 4 commits into from
Jun 18, 2020

Conversation

fifoosid
Copy link
Contributor

BREAKING_CHANGE: ui5-datepicker is renamed to ui5-date-picker

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to also define the old version for some time before breaking it completely.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing: we have this.getMetadata().getTag(), this _getElementsWithMultipleTags in UI5Element look very strange to me. I would go for a implementation at metadata level.

@fifoosid fifoosid closed this Jun 16, 2020
@fifoosid fifoosid reopened this Jun 16, 2020
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the tags and metadata, I thought about it and I would like to see the following API:

const metadtata = {
  tag: "ui5-time-picker",
  altTag: "ui5-timepicker"
}

and then in Metadata.js just a new function getAltTag and for the ones that have it, we'll register it twice.

@fifoosid fifoosid merged commit d972ec2 into master Jun 18, 2020
@fifoosid fifoosid deleted the datepicker-tag branch June 18, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants