Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-datepicker): rename event 'liveChange' to 'input' #394

Merged
merged 3 commits into from
May 16, 2019
Merged

refactor(ui5-datepicker): rename event 'liveChange' to 'input' #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9456088
refactor(ui5-datepicker): rename 'liveChange' to 'input'
ilhan007 May 15, 2019
be0ece9
update test pages
ilhan007 May 15, 2019
43c9ae0
use ui5-input
ilhan007 May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/main/src/DatePicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,14 @@ const metadata = {
* @public
*/
change: {},

/**
* Fired when the value of the <code>ui5-datepicker</code> is changed,
* for example at each keypress.
* Fired when the value of the <code>ui5-datepicker</code> is changed at each key stroke.
*
* @event
* @public
*/
liveChange: {},
input: {},
},
};

Expand Down Expand Up @@ -353,7 +353,7 @@ class DatePicker extends UI5Element {
const isValid = this.isValid(nextValue);

this.value = nextValue;
this.fireEvent("liveChange", { value: nextValue, valid: isValid });
this.fireEvent("input", { value: nextValue, valid: isValid });
}

/**
Expand Down
10 changes: 5 additions & 5 deletions packages/main/test/sap/ui/webcomponents/main/pages/DatePicker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ <h3>placeholder + title + events</h3>
title='Delivery Date!'>
</ui5-datepicker>
<ui5-label id="lblChange">change: N/A</ui5-label><br/>
<ui5-label id="lblLiveChange">liveChange: N/A</ui5-label><br/>
<ui5-label id="lblLiveChange">input: N/A</ui5-label><br/>

<h3>format-pattern - 'short', value - 'tomorrow'</h3>
<ui5-datepicker id='dp6'
Expand Down Expand Up @@ -96,12 +96,12 @@ <h3>japanese calendar type</h3>
console.log('change: ', e.detail);
labelChange.innerHTML = 'change: ' + JSON.stringify(e.detail);
});
dp.addEventListener('ui5-liveChange', function(e) {
console.log('liveChange: ', e.detail);
labelLiveChange.innerHTML = 'liveChange: ' + JSON.stringify(e.detail);
dp.addEventListener('ui5-input', function(e) {
console.log('input: ', e.detail);
labelLiveChange.innerHTML = 'input: ' + JSON.stringify(e.detail);
});

$('#ui5-datepicker--startDate').on('liveChange change', (function(e) {
$('#ui5-datepicker--startDate').on('ui5-input change', (function(e) {
var dp = $('#ui5-datepicker--startDate')[0];
dp.setAttribute('value-state', e.detail.valid ? 'None' : 'Error');
$('#startDate').val($('#ui5-datepicker--startDate').val());
Expand Down
16 changes: 8 additions & 8 deletions packages/main/test/sap/ui/webcomponents/main/pages/DatePicker_fg.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@
</head>
<body>
<div class="header">
<ui5-radiobutton id="sap_fiori_3" group="theme" text="Fiori 3" selected></ui5-radiobutton>
<ui5-radiobutton id="sap_belize_hcb" group="theme" text="HCB_Custom"></ui5-radiobutton>
<ui5-radiobutton id="sap_belize" group="theme" text="Belize"></ui5-radiobutton>
<ui5-radiobutton id="sap_fiori_3" name="theme" text="Fiori 3" selected></ui5-radiobutton>
<ui5-radiobutton id="sap_belize_hcb" name="theme" text="HCB_Custom"></ui5-radiobutton>
<ui5-radiobutton id="sap_belize" name="theme" text="Belize"></ui5-radiobutton>
</div>

<div class="content">
Expand All @@ -86,7 +86,7 @@
$(function () {
var pickers = $('ui5-datepicker');

pickers.on('liveChange change', (function(e) {
pickers.on('input change', (function(e) {
this.setAttribute('value-state', e.detail.valid ? 'None' : 'Error');
$('#startDate').val($(this).val());
$('#startDate').trigger('change');
Expand Down Expand Up @@ -144,11 +144,11 @@

// theme change sample
var Theming = window["sap-ui-webcomponents-main-bundle"].Theming;
Theming.addCustomCSS('ui5-input', 'sap_belize_hcb', inputCSS);
Theming.addCustomCSS('ui5-icon', 'sap_belize_hcb', iconCSS);
Theming.addCustomCSS('ui5-input', inputCSS);
Theming.addCustomCSS('ui5-icon', iconCSS);

$('ui5-radiobutton[group="theme"]').on("select", function (event) {
if (event.detail.selected) {
$('ui5-radiobutton[name="theme"]').on("select", function (event) {
if (event.target.selected) {
var theme = event.target.id;
if (theme === "sap_belize_hcb") {
// only for the radio buttons sample page
Expand Down
4 changes: 2 additions & 2 deletions packages/main/test/sap/ui/webcomponents/main/samples/DatePicker.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ <h3>DatePicker with Placeholder, Tooltip, Events, and ValueState</h3>
dp.setAttribute('value-state', e.detail.valid ? 'None' : 'Error');
console.log('change: ', e.detail);
});
dp.addEventListener('liveChange', (e) => console.log('liveChange: ', e.detail));
dp.addEventListener('input', (e) => console.log('input: ', e.detail));
</script>
</xmp></pre>
</section>
Expand Down Expand Up @@ -178,7 +178,7 @@ <h3>DatePicker with Buddhist Calendar Type</h3>
dp.setAttribute('value-state', e.detail.valid? 'None' : 'Error');
console.log('change: ', e.detail);
});
dp.addEventListener('liveChange', function(e) {console.log('liveChange: ', e.detail)});
dp.addEventListener('input', function(e) {console.log('input: ', e.detail)});
</script>

<script defer src="../../../../../../www/samples/settings.js"></script>
Expand Down