Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-badge): styles clean up #647

Merged
merged 1 commit into from
Jul 23, 2019
Merged

refactor(ui5-badge): styles clean up #647

merged 1 commit into from
Jul 23, 2019

Conversation

ilhan007
Copy link
Member

  • remove element tag within host selector
  • avoid slot element rendering if no icon (slot) is set

@ilhan007
refactor(ui5-badge): styles clean up
1799357 
- remove element tag within host selector
- avoid slot element rendering if no icon (slot) is set
MapTo0
MapTo0 reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I would change is the __has-icon implementation. Can you add it as a private state to the component and get rid of onBeforeRendering and hasIcon getter?

@vladitasev vladitasev self-requested a review July 23, 2019 12:24
@ilhan007 ilhan007 merged commit d143c98 into master Jul 23, 2019
@ilhan007 ilhan007 deleted the refactor-badge-styles branch July 23, 2019 12:32
@MapTo0 MapTo0 mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MapTo0 MapTo0 MapTo0 left review comments

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilhan007 @MapTo0 @vladitasev