Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: align all inputs to use same CSS for styling #793

Merged
merged 10 commits into from
Sep 30, 2019
Merged

refactor: align all inputs to use same CSS for styling #793

merged 10 commits into from
Sep 30, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Sep 25, 2019

  • all input like elements such as Input, MultiComboBox, Select use the same CSS for styling host
  • all icons than needs to be styled as input icons have a common CSS - InputIcon.css
  • users can now overstyle all input elements by setting styles to host
  • fixes tiny bug in Select when Picker is open - icon background color should be pressed
  • adds a better keyboard handling for MultiComboBox

FIXES: #766

MapTo0 and others added 4 commits September 25, 2019 17:38
@MapTo0
refactor: align all inputs to use same CSS for styling
91d8987 
- all input like elements such as Input, MultiComboBox, Select use the same CSS for styling host
- all icons than needs to be styled as input icons have a common CSS - InputIcon.css
- users can now overstyle all input elements by setting styles to host
- fixes tiny bug in Select when Picker is open - icon background color should be pressed
- adds a better keyboard handling for MultiComboBox

FIXES: #766
@MapTo0
prevent back navigation in browser when backspace is pressed on an em…
d76eea5 
…pty input
@MapTo0
add test for MCB kbh
73b8460
@vladitasev
Merge remote-tracking branch 'origin/master' into shared-input-styles
3b016b9
vladitasev
vladitasev requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textarea has no border on IE11, all others are fine

vladitasev
vladitasev requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check HCB theme - when you hover/click the icon to the right (arrow for select, calendar icon for datepicker), the orange background doesn't extend to the bottom of the input

vladitasev
vladitasev previously approved these changes Sep 27, 2019
View reviewed changes
@MapTo0 MapTo0 merged commit 3f26f2c into master Sep 30, 2019
@MapTo0 MapTo0 deleted the shared-input-styles branch September 30, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiComboBox - Deleting items should be possible with backspace
3 participants
@MapTo0 @ilhan007 @vladitasev