Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-form): introduce Form web component #8281

Merged
merged 51 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
dba3dbd
feat: introduce Form component
ilhan007 Nov 20, 2023
046fb70
chore: progress
ilhan007 Nov 21, 2023
0c77766
Merge branch 'main' into feat-form
ilhan007 Dec 14, 2023
8e6a867
chore: progress
ilhan007 Dec 18, 2023
c275862
Merge branch 'main' into feat-form
ilhan007 Dec 19, 2023
5544dff
chore: progress
ilhan007 Dec 19, 2023
f83170f
Merge branch 'main' into feat-form
ilhan007 Dec 19, 2023
261dc74
chore: progress 1
ilhan007 Jan 4, 2024
288e86c
Merge branch 'main' into feat-form
ilhan007 Jan 4, 2024
df36ba4
chore: progress
ilhan007 Jan 8, 2024
c394ec5
chore: progress
ilhan007 Jan 12, 2024
1ea2f65
chore: progress
ilhan007 Jan 13, 2024
f23850a
Merge branch 'main' into feat-form
ilhan007 Jan 14, 2024
bac7b7e
Merge branch 'main' into feat-form
ilhan007 Jan 26, 2024
becaf43
Merge branch 'main' into feat-form
ilhan007 Feb 4, 2024
5cd556a
Merge branch 'main' into feat-form
ilhan007 Feb 13, 2024
eb3c070
Merge branch 'main' into feat-form
ilhan007 Feb 13, 2024
347f49b
chore: clean up
ilhan007 Feb 13, 2024
9fb0fed
chore: add tests
ilhan007 Feb 14, 2024
cbcb90b
chore: polishing
ilhan007 Feb 14, 2024
19576b2
chore: take labelSpan set from outside over the built-in logic
ilhan007 Feb 15, 2024
ccaa1c6
chore: address comments
ilhan007 Feb 15, 2024
56bd044
chore: support non-adoptedStyleSheets case
ilhan007 Feb 15, 2024
f5f9b3b
chore: fix failing test
ilhan007 Feb 16, 2024
dce8e6b
Merge branch 'main' into feat-form
ilhan007 Feb 19, 2024
64f582c
chore: remove obsolete files, previously used in test pages
ilhan007 Feb 19, 2024
39a98c2
chore: create dynamic styles with adopted stylesheet only
ilhan007 Feb 21, 2024
a5ae034
Merge branch 'main' into feat-form
ilhan007 Feb 21, 2024
9646c0c
Merge branch 'main' into feat-form
ilhan007 May 2, 2024
c1f5334
chore: update jsdoc to "md" format
ilhan007 May 2, 2024
bc0453b
chore: progress
ilhan007 May 8, 2024
9f5ad4e
Merge branch 'main' into feat-form
ilhan007 May 8, 2024
9fa82bd
docs: add website samples
ilhan007 May 8, 2024
778f6e7
chore: add more samples, fix comments
ilhan007 May 10, 2024
1e7a704
chore: fix review comments
ilhan007 May 10, 2024
b0f6570
chore: remove adaptive form item responsiveness
ilhan007 May 13, 2024
3bdafe0
chore: add compact/cozy for group heading size
ilhan007 May 13, 2024
4d37501
chore: add experimental tag
ilhan007 May 13, 2024
f3c5626
Merge branch 'main' into feat-form
ilhan007 May 13, 2024
25d132c
Merge branch 'main' into feat-form
ilhan007 May 13, 2024
8d37e41
chore: update since tag
ilhan007 May 13, 2024
43b4c59
chore: add FormItem columnSpan
ilhan007 May 14, 2024
9f40126
chore: describe the slot with the classes more explicitly
ilhan007 May 14, 2024
303d944
chore: update samples
ilhan007 May 15, 2024
e368739
chore: use ui5-text in the Edit sample
ilhan007 May 15, 2024
7dfe59d
chore: revert obsolete change
ilhan007 May 15, 2024
143acc2
chore: add type String to prop decorator
ilhan007 May 15, 2024
0efeea8
chore: properly describe props with undefined default
ilhan007 May 15, 2024
c25763a
chore: improve JSDoc
ilhan007 May 15, 2024
7010c4f
chore: add custom header sample
ilhan007 May 15, 2024
f78244a
chore: use string literal for props of enum type
ilhan007 May 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,4 @@
"packages/website",
"packages/create-package"
]
}
}
2 changes: 1 addition & 1 deletion packages/base/src/features/OpenUI5Support.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class OpenUI5Support {
timezone: Localization.getTimezone(),
calendarType: Formatting.getCalendarType(),
formatSettings: {
firstDayOfWeek: CalendarUtils.getWeekConfigurationValues().firstDayOfWeek,
firstDayOfWeek: CalendarUtils?.getWeekConfigurationValues().firstDayOfWeek,
legacyDateCalendarCustomizing: Formatting.getCustomIslamicCalendarData?.()
?? Formatting.getLegacyDateCalendarCustomizing?.(),
},
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/DatePicker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ class DatePicker extends DateComponentBase implements IFormElement {
* Defines the open or closed state of the popover.
* @public
* @default false
* @since 2.0
* @since 2.0.0
*/
@property({ type: Boolean })
open!: boolean;
Expand Down
35 changes: 35 additions & 0 deletions packages/main/src/Form.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<div class="ui5-form-root" role="form" aria-labelledby="{{ariaLabelledByID}}">
<div class="ui5-form-header" part="header">
{{#if hasCustomHeader}}
<slot name="header"></slot>
{{else}}
<ui5-title id="{{_id}}-header-text" level="H4">{{ headerText }}</ui5-title>
{{/if}}
</div>

<div class="ui5-form-layout" part="layout">
{{#if this.hasGroupItems}}
{{#each groupItemsInfo}}
<div class="ui5-form-column {{this.classes}}" part="column">
<div class="ui5-form-group">
{{#if this.groupItem.headerText}}
<div class="ui5-form-group-heading">
<ui5-title level="H6">{{ this.groupItem.headerText }}</ui5-title>
</div>
{{/if}}

<div class="ui5-form-group-layout">
<slot name="{{this.groupItem._individualSlot}}"></slot>
</div>
</div>
</div>
{{/each}}
{{else}}
{{#each itemsInfo}}
<div class="ui5-form-item {{this.classes}}">
<slot name="{{this.item._individualSlot}}"></slot>
</div>
{{/each}}
{{/if}}
</div>
</div>