POC refactor(ui5-select-menu, ui5-select-menu-option): removed components #8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Apr 11, 2024
| @customElement("ui5-option") | ||
| class Option extends UI5Element implements IOption { | ||
| @customElement({ | ||
| tag: "ui5-option", |
There was a problem hiding this comment.
why do we extend CustomListItem class and at the same time we use the component of the template?
packages/main/src/themes/Option.css
Outdated
| height: var(--_ui5_list_item_dropdown_base_height); | ||
| } | ||
|
|
||
| :host ::part(icon) { |
There was a problem hiding this comment.
this one is strange. you don't have icon part defined in your option.hbs file. why do we need it?
| @@ -24,24 +24,570 @@ | |||
| <section> | |||
| <ui5-title>Select + SelectMenu + SelectMenuOption</ui5-title><br> | |||
|
|
|||
| <ui5-select id="sel" menu="selectOptions"> | |||
| <ui5-select id="sel"> | |||
| <div class="selectLabel" slot="label"> | |||
| <span id="mainText">Skirt [3]</span> | |||
| <ui5-avatar id="avatar" size="XS" initials="S"></ui5-avatar> | |||
There was a problem hiding this comment.
some component in this test page doesn't work.
dobrinyonkov
changed the title
- fixed review comments
- fixed eslint error
- options are now being individual slots
|
Moved to #8903 as this PR is corrupted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8461, #7887