Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create theme-base and fiori packages, and move ShellBar #887

Merged
merged 44 commits into from
Nov 15, 2019

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Oct 25, 2019

  • Create a theme-base package that contains the common css variables for all other packages. This includes component-specific variables that require derived colors. This package uses lessjs for the calculations.
  • Create a fiori package, integrate it in the build and move ShellBar.js there.
  • The default theme no longer relies on CSS vars fallback values. CSS vars are always explicitly included.
  • Update README files to indicate that users may need to install an additional NPM package and all other relevant information.

BREAKING CHANGE: ShellBar.js moved to another package. Please change all references to:
@ui5/webcomponents/dist/ShellBar.js -> @ui5/webcomponents-fiori/dist/ShellBar.js
and
@ui5/webcomponents/dist/ShellBarItem.js -> @ui5/webcomponents-fiori/dist/ShellBarItem.js

@vladitasev vladitasev changed the title refactor: move ShellBar to a new fiori package refactor: create theme-base and fiori packages, and move ShellBar Nov 14, 2019
Copy link
Contributor

@pskelin pskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, works locally

@vladitasev vladitasev merged commit 17c25ff into master Nov 15, 2019
@vladitasev vladitasev deleted the fiori-package branch November 15, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants