Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-notification): implement keyboard navigation spec #8975

Merged
merged 20 commits into from
May 21, 2024

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented May 15, 2024

ui5-notification-list component is included to enhance accessibility.

BREAKING CHANGE: Instead of ui5-list, ui5-notification-list should be used as a container for ui5-li-notification-group and ui5-li-notification components.

Previously the application developers were defining notifications in this way:

<ui5-list>
        <ui5-li-notification-group title-text="Group Title" >
            <ui5-li-notification..

To support accessibility, developers should now use the ui5-notification-list as seen below:

<ui5-notification-list>
        <ui5-li-notification-group title-text="Group Title" >
            <ui5-li-notification..

@TeodorTaushanov TeodorTaushanov changed the title feature(ui5-notification-list): control implementation fix(ui5-notification): implement keyboard navigation spec May 16, 2024
@TeodorTaushanov TeodorTaushanov marked this pull request as ready for review May 20, 2024 11:31
@TeodorTaushanov TeodorTaushanov requested review from BorisDafov and a team May 20, 2024 11:31
@TeodorTaushanov TeodorTaushanov merged commit d68c883 into main May 21, 2024
10 checks passed
@TeodorTaushanov TeodorTaushanov deleted the notifications_keyboard branch May 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants