-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-time-picker): introduce open
property
#9001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip1000
reviewed
May 20, 2024
didip1000
approved these changes
May 21, 2024
tsanislavgatev
requested changes
May 27, 2024
tsanislavgatev
approved these changes
May 27, 2024
openPicker
method with open
propertyopen
property
open
propertyopen
property, replacing openPicker()
method
open
property, replacing openPicker()
methodopen
property
nnaydenow
approved these changes
May 27, 2024
open
propertyopen
property
1 task
Please add an event every time you introduce a user-controlled property: #9076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
open
property to replace theopenPicker
method in theui5-time-picker
component.BREAKING CHANGE: Removed
openPicker()
,closePicker()
, andisOpen()
methods.Before, the
ui5-time-picker
popover could be opened and closed by callingopenPicker()
andclosePicker()
:Now, the popover is opened and closed by setting the
open
property to true or false:Related to: #8461