Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-time-picker): introduce open property #9001

Merged
merged 4 commits into from
May 27, 2024
Merged

feat(ui5-time-picker): introduce open property #9001

merged 4 commits into from
May 27, 2024

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented May 19, 2024

Add open property to replace the openPicker method in the ui5-time-picker component.

BREAKING CHANGE: Removed openPicker(), closePicker(), and isOpen() methods.

Before, the ui5-time-picker popover could be opened and closed by calling openPicker() and closePicker():

const timePicker = document.getElementById("exampleID");
timePicker.openPicker();
timePicker.closePicker();

Now, the popover is opened and closed by setting the open property to true or false:

const timePicker = document.getElementById("exampleID");
timePicker.open = true;
timePicker.open = false;

Related to: #8461

@vladitasev vladitasev requested review from vladitasev and removed request for vladitasev May 20, 2024 08:07
packages/main/src/TimePicker.ts Outdated Show resolved Hide resolved
packages/main/src/TimePicker.ts Outdated Show resolved Hide resolved
packages/main/src/TimePicker.ts Outdated Show resolved Hide resolved
@hinzzx hinzzx marked this pull request as ready for review May 27, 2024 13:14
@hinzzx hinzzx requested review from ilhan007 and nnaydenow May 27, 2024 13:14
@hinzzx hinzzx changed the title feat(ui5-timepicker): replace openPicker method with open property feat(ui5-timepicker): introduce open property May 27, 2024
@hinzzx hinzzx changed the title feat(ui5-timepicker): introduce open property feat(ui5-timepicker): introduce open property, replacing openPicker() method May 27, 2024
@nnaydenow nnaydenow changed the title feat(ui5-timepicker): introduce open property, replacing openPicker() method feat(ui5-timepicker): introduce open property May 27, 2024
@nnaydenow nnaydenow changed the title feat(ui5-timepicker): introduce open property feat(ui5-time-picker): introduce open property May 27, 2024
@hinzzx hinzzx merged commit 1c1cea6 into main May 27, 2024
10 checks passed
@hinzzx hinzzx deleted the timepicker-open branch May 27, 2024 14:16
@vladitasev
Copy link
Contributor

Please add an event every time you introduce a user-controlled property: #9076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants