Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-dialog): fix focusing when dialog is open from OpenUI5 dialog #9183

Merged
merged 10 commits into from
Jun 17, 2024
Merged

fix(ui5-dialog): fix focusing when dialog is open from OpenUI5 dialog #9183

merged 10 commits into from
Jun 17, 2024

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Jun 11, 2024 •
edited
Loading

Part of #9028

@TeodorTaushanov TeodorTaushanov requested review from vladitasev and a team June 12, 2024 13:11
alexandar-mitsev
alexandar-mitsev requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fixing this issue reveals a bug where "ESC" key can not close the openui5 dialog, we can report it as a separate issue

packages/main/test/pages/DialogAndOpenUI5Dialog.html Show resolved Hide resolved
packages/main/test/pages/DialogAndOpenUI5Dialog.html Outdated Show resolved Hide resolved
packages/main/test/pages/DialogAndOpenUI5Dialog.html Outdated Show resolved Hide resolved
packages/base/src/features/patchPopup.ts Outdated Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov merged commit d067e13 into main Jun 17, 2024
10 checks passed
@TeodorTaushanov TeodorTaushanov deleted the dialogs_combinations branch June 17, 2024 08:02
kgogov pushed a commit that referenced this pull request Jun 17, 2024
@TeodorTaushanov @kgogov
fix(ui5-dialog): fix focusing when dialog is open from OpenUI5 dialog (…
e09be96 
…#9183)

fix(ui5-dialog): fix focusing when dialog is open from OpenUI5 dialog
@TeodorTaushanov TeodorTaushanov mentioned this pull request Jun 17, 2024
Merged
TeodorTaushanov added a commit that referenced this pull request Jun 20, 2024
@TeodorTaushanov
fix(ui5-dialog): fix focusing when dialog is open from OpenUI5 dialog (…
e2a19fa 
…#9204)

Part of #9028
Downport of #9183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandar-mitsev alexandar-mitsev alexandar-mitsev approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TeodorTaushanov @alexandar-mitsev