fix(ui5-li-notification): enhance accessibility #9192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the "More"/"Less" button (link) is not read when focusing the notification item. Now the "More"/"Less" button is announced only when the focus is on it. - “tag” word before “Important” is not removed since it comes from the ui5-tag component and needs to be announced fixes #9161
LidiyaGeorgieva
requested review from
GerganaKremenska,
BorisDafov and
TeodorTaushanov
BorisDafov
reviewed
Jun 13, 2024
GerganaKremenska
approved these changes
Jun 14, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jun 14, 2024
- the "More"/"Less" button (link) is not read when focusing the notification item. Now the "More"/"Less" button is announced only when the focus is on it. - “tag” word before “Important” is not removed since it comes from the ui5-tag component and needs to be announced fixes #9161
kgogov
pushed a commit
that referenced
this pull request
Jun 17, 2024
- the "More"/"Less" button (link) is not read when focusing the notification item. Now the "More"/"Less" button is announced only when the focus is on it. - “tag” word before “Important” is not removed since it comes from the ui5-tag component and needs to be announced fixes #9161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9161